Bump openssl from 0.10.55 to 0.10.60 #387
mellowagainAnnotations
84 warnings
|
usage of an `Arc` that is not `Send` or `Sync`:
src/main.rs#L95
warning: usage of an `Arc` that is not `Send` or `Sync`
--> src/main.rs:95:22
|
95 | let cookie = Arc::new(read_magic_database().expect_or_log("Failed to libmagic database"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: the trait `Send` is not implemented for `Cookie`
= note: the trait `Sync` is not implemented for `Cookie`
= note: required for `Arc<Cookie>` to implement `Send` and `Sync`
= help: consider using an `Rc` instead or wrapping the inner type with a `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
= note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
|
|
the borrowed expression implements the required traits:
src/verification.rs#L17
warning: the borrowed expression implements the required traits
--> src/verification.rs:17:15
|
17 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/user.rs#L156
warning: the borrowed expression implements the required traits
--> src/user.rs:156:31
|
156 | .bind(&session.user_id)
| ^^^^^^^^^^^^^^^^ help: change this to: `session.user_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
returning the result of a `let` binding from a block:
src/user.rs#L63
warning: returning the result of a `let` binding from a block
--> src/user.rs:63:9
|
56 | / ... let user = sqlx::query_as::<_, User>("select * from users where id = (select owner from emails where lower(email) = lower($1) limit...
57 | | ... .bind(email)
58 | | ... .fetch_optional(executor)
59 | | ... .await
60 | | ... .ok()
61 | | ... .flatten();
| |_____________________- unnecessary `let` binding
62 | ...
63 | ... user
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
help: return the expression directly
|
56 ~
57 |
58 ~ sqlx::query_as::<_, User>("select * from users where id = (select owner from emails where lower(email) = lower($1) limit 1) limit 1")
59 + .bind(email)
60 + .fetch_optional(executor)
61 + .await
62 + .ok()
63 + .flatten()
|
|
|
returning the result of a `let` binding from a block:
src/user.rs#L47
warning: returning the result of a `let` binding from a block
--> src/user.rs:47:9
|
40 | / let user = sqlx::query_as::<_, User>("select * from users where lower(username) = lower($1) limit 1")
41 | | .bind(username)
42 | | .fetch_optional(executor)
43 | | .await
44 | | .ok()
45 | | .flatten();
| |_______________________- unnecessary `let` binding
46 |
47 | user
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
40 ~
41 |
42 ~ sqlx::query_as::<_, User>("select * from users where lower(username) = lower($1) limit 1")
43 + .bind(username)
44 + .fetch_optional(executor)
45 + .await
46 + .ok()
47 + .flatten()
|
|
|
name `SSO` contains a capitalized acronym:
src/sso/mod.rs#L14
warning: name `SSO` contains a capitalized acronym
--> src/sso/mod.rs:14:19
|
14 | pub(crate) struct SSO {
| ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Sso`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
|
|
the borrowed expression implements the required traits:
src/sso/gitlab_sso.rs#L158
warning: the borrowed expression implements the required traits
--> src/sso/gitlab_sso.rs:158:23
|
158 | .bind(&primary)
| ^^^^^^^^ help: change this to: `primary`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/gitlab_sso.rs#L156
warning: the borrowed expression implements the required traits
--> src/sso/gitlab_sso.rs:156:23
|
156 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/gitlab_sso.rs#L120
warning: the borrowed expression implements the required traits
--> src/sso/gitlab_sso.rs:120:19
|
120 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/github_sso.rs#L173
warning: the borrowed expression implements the required traits
--> src/sso/github_sso.rs:173:23
|
173 | .bind(&public)
| ^^^^^^^ help: change this to: `public`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/github_sso.rs#L172
warning: the borrowed expression implements the required traits
--> src/sso/github_sso.rs:172:23
|
172 | .bind(&primary)
| ^^^^^^^^ help: change this to: `primary`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/github_sso.rs#L170
warning: the borrowed expression implements the required traits
--> src/sso/github_sso.rs:170:23
|
170 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/github_sso.rs#L137
warning: the borrowed expression implements the required traits
--> src/sso/github_sso.rs:137:19
|
137 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/bitbucket_sso.rs#L152
warning: the borrowed expression implements the required traits
--> src/sso/bitbucket_sso.rs:152:23
|
152 | .bind(&primary)
| ^^^^^^^^ help: change this to: `primary`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/bitbucket_sso.rs#L150
warning: the borrowed expression implements the required traits
--> src/sso/bitbucket_sso.rs:150:23
|
150 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/sso/bitbucket_sso.rs#L119
warning: the borrowed expression implements the required traits
--> src/sso/bitbucket_sso.rs:119:19
|
119 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/session.rs#L99
warning: the borrowed expression implements the required traits
--> src/session.rs:99:19
|
99 | .bind(&self.user_id)
| ^^^^^^^^^^^^^ help: change this to: `self.user_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/session.rs#L81
warning: the borrowed expression implements the required traits
--> src/session.rs:81:19
|
81 | .bind(&self.user_id)
| ^^^^^^^^^^^^^ help: change this to: `self.user_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/session.rs#L80
warning: the borrowed expression implements the required traits
--> src/session.rs:80:19
|
80 | .bind(&now)
| ^^^^ help: change this to: `now`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/session.rs#L78
warning: the borrowed expression implements the required traits
--> src/session.rs:78:19
|
78 | .bind(&ip_address)
| ^^^^^^^^^^^ help: change this to: `ip_address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/session.rs#L44
warning: the borrowed expression implements the required traits
--> src/session.rs:44:19
|
44 | .bind(&ip_address)
| ^^^^^^^^^^^ help: change this to: `ip_address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/session.rs#L43
warning: the borrowed expression implements the required traits
--> src/session.rs:43:19
|
43 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/user_verify.rs#L39
warning: the borrowed expression implements the required traits
--> src/routes/user/user_verify.rs:39:15
|
39 | .bind(&row_id)
| ^^^^^^^ help: change this to: `row_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/user_verify.rs#L34
warning: the borrowed expression implements the required traits
--> src/routes/user/user_verify.rs:34:15
|
34 | .bind(&user_id)
| ^^^^^^^^ help: change this to: `user_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/user_verify.rs#L23
warning: the borrowed expression implements the required traits
--> src/routes/user/user_verify.rs:23:15
|
23 | .bind(&token)
| ^^^^^^ help: change this to: `token`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/user_create.rs#L106
warning: the borrowed expression implements the required traits
--> src/routes/user/user_create.rs:106:15
|
106 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/sso.rs#L73
warning: the borrowed expression implements the required traits
--> src/routes/user/sso.rs:73:23
|
73 | .bind(&sso.user_id)
| ^^^^^^^^^^^^ help: change this to: `sso.user_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/api/add_key.rs#L59
warning: the borrowed expression implements the required traits
--> src/routes/user/api/add_key.rs:59:15
|
59 | .bind(&body.expiration_date)
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `body.expiration_date`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/user/api/add_key.rs#L54
warning: the borrowed expression implements the required traits
--> src/routes/user/api/add_key.rs:54:15
|
54 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this `RefCell` reference is held across an `await` point:
src/routes/repository/repo_view.rs#L173
warning: this `RefCell` reference is held across an `await` point
--> src/routes/repository/repo_view.rs:173:9
|
173 | let extensions = request.extensions();
| ^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> src/routes/repository/repo_view.rs:175:62
|
175 | render(None, repo, &repo_owner.0, web_user, transaction).await
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
|
|
call to `reserve` immediately after creation:
src/routes/repository/repo_view.rs#L73
warning: call to `reserve` immediately after creation
--> src/routes/repository/repo_view.rs:73:5
|
73 | / let mut files = Vec::<RepoFile>::new();
74 | | files.reserve(tree.entries.len().min(1000));
| |________________________________________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut files = Vec::with_capacity(tree.entries.len().min(1000));`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization
|
|
the borrowed expression implements the required traits:
src/routes/repository/repo_view.rs#L34
warning: the borrowed expression implements the required traits
--> src/routes/repository/repo_view.rs:34:15
|
34 | .bind(&repo.id)
| ^^^^^^^^ help: change this to: `repo.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/issues.rs#L37
warning: the borrowed expression implements the required traits
--> src/routes/repository/issues.rs:37:19
|
37 | .bind(&issue.author)
| ^^^^^^^^^^^^^ help: change this to: `issue.author`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/issues.rs#L27
warning: the borrowed expression implements the required traits
--> src/routes/repository/issues.rs:27:15
|
27 | .bind(&repo.id)
| ^^^^^^^^ help: change this to: `repo.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this `RefCell` reference is held across an `await` point:
src/routes/repository/issues.rs#L65
warning: this `RefCell` reference is held across an `await` point
--> src/routes/repository/issues.rs:65:9
|
65 | let extensions = request.extensions();
| ^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> src/templates/mod.rs:170:101
|
170 | let domain = $crate::config::get_optional_setting::<String, _>("domain", &mut $transaction).await?.unwrap_or_default();
| ^^^^^
...
177 | let template = $crate::templates::render($template_name, &$context).await?;
| ^^^^^
178 |
179 | $transaction.commit().await?;
| ^^^^^
|
::: src/routes/repository/issues.rs:73:5
|
73 | render_template!("repo/issues.html", context, transaction)
| ----------------------------------------------------------
| |
| in this macro invocation
| in this macro invocation
| in this macro invocation
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: this warning originates in the macro `render_template` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
the borrowed expression implements the required traits:
src/routes/repository/git/git_receive_pack.rs#L173
warning: the borrowed expression implements the required traits
--> src/routes/repository/git/git_receive_pack.rs:173:15
|
173 | .bind(&repo.id)
| ^^^^^^^^ help: change this to: `repo.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/git/git_receive_pack.rs#L148
warning: the borrowed expression implements the required traits
--> src/routes/repository/git/git_receive_pack.rs:148:15
|
148 | .args(&["gc", "--auto", "--quiet"])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["gc", "--auto", "--quiet"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this `RefCell` reference is held across an `await` point:
src/routes/repository/commits.rs#L27
warning: this `RefCell` reference is held across an `await` point
--> src/routes/repository/commits.rs:27:9
|
27 | let extensions = request.extensions();
| ^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> src/routes/repository/commits.rs:34:55
|
34 | let libgit2_repo = repo.libgit2(&mut transaction).await?;
| ^^^^^
35 |
36 | context.try_insert("branches", &all_branches(&libgit2_repo).await?)?;
| ^^^^^
37 | context.try_insert("tags", &all_tags(&libgit2_repo, None).await?)?;
| ^^^^^
...
41 | let commit_ids = all_commits(&libgit2_repo, searching_ref, 20).await?;
| ^^^^^
...
46 | let (name, uid, email) = commit.author().try_disassemble(&mut transaction).await;
| ^^^^^
...
77 | return render_template!("repo/commit_list_component.html", context, transaction);
| -------------------------------------------------------------------------
| |
| in this macro invocation
| in this macro invocation
| in this macro invocation
...
80 | render_template!("repo/commits.html", context, transaction)
| -----------------------------------------------------------
| |
| in this macro invocation
| in this macro invocation
| in this macro invocation
|
::: src/templates/mod.rs:170:101
|
170 | let domain = $crate::config::get_optional_setting::<String, _>("domain", &mut $transaction).await?.unwrap_or_default();
| ^^^^^
...
177 | let template = $crate::templates::render($template_name, &$context).await?;
| ^^^^^
178 |
179 | $transaction.commit().await?;
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: this warning originates in the macro `render_template` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
parameter is only used in recursion:
src/routes/repository/blobs/directory.rs#L142
warning: parameter is only used in recursion
--> src/routes/repository/blobs/directory.rs:142:95
|
142 | ..._ref: TreeRef<'a>, path: &str, repo: &'a GitoxideRepository, store: Arc<Store>, buffer: &'a mut Vec<u8>) -> Result<Tree> {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_repo`
|
note: parameter used here
--> src/routes/repository/blobs/directory.rs:159:68
|
159 | recursively_visit_tree(reference, tree_ref, remaining, repo, store, &mut buffer).await
| ^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
|
|
parameter is only used in recursion:
src/routes/repository/blobs/directory.rs#L142
warning: parameter is only used in recursion
--> src/routes/repository/blobs/directory.rs:142:37
|
142 | async fn recursively_visit_tree<'a>(reference: &Reference, tree_ref: TreeRef<'a>, path: &str, repo: &'a GitoxideRepository, store: Arc<St...
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference`
|
note: parameter used here
--> src/routes/repository/blobs/directory.rs:159:36
|
159 | recursively_visit_tree(reference, tree_ref, remaining, repo, store, &mut buffer).await
| ^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
|
|
call to `reserve` immediately after creation:
src/routes/repository/blobs/directory.rs#L67
warning: call to `reserve` immediately after creation
--> src/routes/repository/blobs/directory.rs:67:5
|
67 | / let mut files = Vec::<RepoFile>::new();
68 | | files.reserve(tree.entries.len().min(1000));
| |________________________________________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut files = Vec::with_capacity(tree.entries.len().min(1000));`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization
= note: `#[warn(clippy::reserve_after_initialization)]` on by default
|
|
the borrowed expression implements the required traits:
src/routes/repository/blobs/directory.rs#L49
warning: the borrowed expression implements the required traits
--> src/routes/repository/blobs/directory.rs:49:15
|
49 | .bind(&repo.id)
| ^^^^^^^^ help: change this to: `repo.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
parameter is only used in recursion:
src/routes/repository/blobs/blob.rs#L122
warning: parameter is only used in recursion
--> src/routes/repository/blobs/blob.rs:122:103
|
122 | ..._ref: TreeRef<'a>, path: &str, repo: &'a GitoxideRepository, store: Arc<Store>, buffer: &'a mut Vec<u8>) -> Result<(String, String, En...
| ^^^^ help: if this is intentional, prefix it with an underscore: `_repo`
|
note: parameter used here
--> src/routes/repository/blobs/blob.rs:140:76
|
140 | recursively_visit_blob_content(reference, tree_ref, remaining, repo, store, &mut buffer).await
| ^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
|
|
parameter is only used in recursion:
src/routes/repository/blobs/blob.rs#L122
warning: parameter is only used in recursion
--> src/routes/repository/blobs/blob.rs:122:45
|
122 | async fn recursively_visit_blob_content<'a>(reference: &Reference, tree_ref: TreeRef<'a>, path: &str, repo: &'a GitoxideRepository, store...
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference`
|
note: parameter used here
--> src/routes/repository/blobs/blob.rs:140:44
|
140 | recursively_visit_blob_content(reference, tree_ref, remaining, repo, store, &mut buffer).await
| ^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `#[warn(clippy::only_used_in_recursion)]` on by default
|
|
this `RefCell` reference is held across an `await` point:
src/routes/repository/api/star.rs#L25
warning: this `RefCell` reference is held across an `await` point
--> src/routes/repository/api/star.rs:25:9
|
25 | let extensions = request.extensions();
| ^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> src/routes/repository/api/star.rs:28:26
|
28 | transaction.commit().await?;
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: `#[warn(clippy::await_holding_refcell_ref)]` on by default
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/import_repo.rs#L70
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/import_repo.rs:70:15
|
70 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/import_repo.rs#L61
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/import_repo.rs:61:15
|
61 | .bind(&name)
| ^^^^^ help: change this to: `name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/import_repo.rs#L60
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/import_repo.rs:60:15
|
60 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/fork_repo.rs#L74
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/fork_repo.rs:74:15
|
74 | .bind(&repo.id)
| ^^^^^^^^ help: change this to: `repo.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/fork_repo.rs#L70
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/fork_repo.rs:70:15
|
70 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/fork_repo.rs#L60
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/fork_repo.rs:60:15
|
60 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/create_repo.rs#L57
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/create_repo.rs:57:15
|
57 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/create_repo.rs#L48
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/create_repo.rs:48:15
|
48 | .bind(&name)
| ^^^^^ help: change this to: `name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/repository/api/create_repo.rs#L47
warning: the borrowed expression implements the required traits
--> src/routes/repository/api/create_repo.rs:47:15
|
47 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/routes/admin/dashboard.rs#L70
warning: the borrowed expression implements the required traits
--> src/routes/admin/dashboard.rs:70:19
|
70 | .bind(&latest_repo.owner)
| ^^^^^^^^^^^^^^^^^^ help: change this to: `latest_repo.owner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/repository.rs#L93
warning: the borrowed expression implements the required traits
--> src/repository.rs:93:19
|
93 | .bind(&self.owner)
| ^^^^^^^^^^^ help: change this to: `self.owner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/repository.rs#L56
warning: the borrowed expression implements the required traits
--> src/repository.rs:56:19
|
56 | .bind(&user_id)
| ^^^^^^^^ help: change this to: `user_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/privileges/privilege.rs#L68
warning: the borrowed expression implements the required traits
--> src/privileges/privilege.rs:68:15
|
68 | .bind(&repo.id)
| ^^^^^^^^ help: change this to: `repo.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/privileges/privilege.rs#L67
warning: the borrowed expression implements the required traits
--> src/privileges/privilege.rs:67:15
|
67 | .bind(&user.id)
| ^^^^^^^^ help: change this to: `user.id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
this function has too many arguments (8/7):
src/git/receive_pack.rs#L29
warning: this function has too many arguments (8/7)
--> src/git/receive_pack.rs:29:1
|
29 | #[instrument(err, skip(writer, store))]
| ^--------------------------------------
| |
| _in this procedural macro expansion
| |
30 | | pub(crate) async fn process_create_update(ref_update: &RefUpdate, repo: &Repository, store: Arc<Store>, db_pool: &PgPool, writer: &mut GitWriter, index_path: Option<&PathBuf>, pack_path: Option<&PathBuf>, raw_pack: &[u8]) -> Result<()...
| |___________________________________________________________________________________________________________________________________________________________________________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the attribute macro `instrument` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
casting to the same type is unnecessary (`u16` -> `u16`):
src/git/io/writer.rs#L127
warning: casting to the same type is unnecessary (`u16` -> `u16`)
--> src/git/io/writer.rs:127:26
|
127 | hex::encode_to_slice((value as u16).to_be_bytes(), &mut buffer).unwrap_or_log();
| ^^^^^^^^^^^^^^ help: try: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
method `ok` is never used:
src/user.rs#L94
warning: method `ok` is never used
--> src/user.rs:94:19
|
93 | impl WebUser {
| ------------ method in this implementation
94 | pub(crate) fn ok(self) -> Option<User> {
| ^^
|
|
fields `provider` and `provider_id` are never read:
src/sso/mod.rs#L16
warning: fields `provider` and `provider_id` are never read
--> src/sso/mod.rs:16:16
|
14 | pub(crate) struct SSO {
| --- fields in this struct
15 | pub(crate) user_id: i32, // User id on our end
16 | pub(crate) provider: SSOProviderType,
| ^^^^^^^^
17 | pub(crate) provider_id: String // User id on the provider end
| ^^^^^^^^^^^
|
|
method `len` is never used:
src/sse.rs#L85
warning: method `len` is never used
--> src/sse.rs:85:19
|
36 | impl Broadcaster {
| ---------------- method in this implementation
...
85 | pub(crate) fn len(&self) -> usize {
| ^^^
|
|
field `repository` is never read:
src/routes/repository/blobs/mod.rs#L19
warning: field `repository` is never read
--> src/routes/repository/blobs/mod.rs:19:16
|
14 | pub(crate) struct BlobRequest {
| ----------- field in this struct
...
19 | pub(crate) repository: String,
| ^^^^^^^^^^
|
|
field `repository` is never read:
src/routes/repository/mod.rs#L38
warning: field `repository` is never read
--> src/routes/repository/mod.rs:38:16
|
36 | pub(crate) struct GitTreeRequest {
| -------------- field in this struct
37 | pub(crate) username: String,
38 | pub(crate) repository: String,
| ^^^^^^^^^^
|
|
function `check_admin` is never used:
src/privileges/privilege.rs#L63
warning: function `check_admin` is never used
--> src/privileges/privilege.rs:63:17
|
63 | generate_check!(check_admin, can_admin);
| ^^^^^^^^^^^
|
= note: this warning originates in the macro `generate_check` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
function `check_manage_issues` is never used:
src/privileges/privilege.rs#L61
warning: function `check_manage_issues` is never used
--> src/privileges/privilege.rs:61:17
|
61 | generate_check!(check_manage_issues, can_manage_issues);
| ^^^^^^^^^^^^^^^^^^^
|
= note: this warning originates in the macro `generate_check` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
fields `id`, `user_id`, and `repo_id` are never read:
src/privileges/privilege.rs#L11
warning: fields `id`, `user_id`, and `repo_id` are never read
--> src/privileges/privilege.rs:11:16
|
10 | pub(crate) struct Privilege {
| --------- fields in this struct
11 | pub(crate) id: i32,
| ^^
12 | pub(crate) user_id: i32,
| ^^^^^^^
13 | pub(crate) repo_id: i32,
| ^^^^^^^
|
|
methods `can_manage_issues` and `can_admin` are never used:
src/privileges/repo_access.rs#L22
warning: methods `can_manage_issues` and `can_admin` are never used
--> src/privileges/repo_access.rs:22:19
|
17 | impl AccessLevel {
| ---------------- methods in this implementation
...
22 | pub(crate) fn can_manage_issues(&self) -> bool {
| ^^^^^^^^^^^^^^^^^
...
36 | pub(crate) fn can_admin(&self) -> bool {
| ^^^^^^^^^
|
|
associated function `find_public_email` is never used:
src/mail.rs#L72
warning: associated function `find_public_email` is never used
--> src/mail.rs:72:20
|
68 | impl Email {
| ---------- associated function in this implementation
...
72 | generate_find!(find_public_email, "public");
| ^^^^^^^^^^^^^^^^^
|
= note: this warning originates in the macro `generate_find` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
methods `write_text_bytes`, `write_binary`, `delimiter`, and `response_end` are never used:
src/git/io/writer.rs#L52
warning: methods `write_text_bytes`, `write_binary`, `delimiter`, and `response_end` are never used
--> src/git/io/writer.rs:52:25
|
14 | impl GitWriter {
| -------------- methods in this implementation
...
52 | pub(crate) async fn write_text_bytes(&mut self, text: &[u8]) -> Result<&mut GitWriter> {
| ^^^^^^^^^^^^^^^^
...
57 | pub(crate) async fn write_binary(&mut self, binary: &[u8]) -> Result<&mut GitWriter> {
| ^^^^^^^^^^^^
...
99 | pub(crate) async fn delimiter(&mut self) -> Result<&mut GitWriter> {
| ^^^^^^^^^
...
104 | pub(crate) async fn response_end(&mut self) -> Result<&mut GitWriter> {
| ^^^^^^^^^^^^
|
|
method `write_text` is never used:
src/git/io/progress_writer.rs#L25
warning: method `write_text` is never used
--> src/git/io/progress_writer.rs:25:19
|
17 | impl ProgressWriter {
| ------------------- method in this implementation
...
25 | pub(crate) fn write_text(&mut self, text: String) {
| ^^^^^^^^^^
|
|
associated function `try_new` is never used:
src/error.rs#L134
warning: associated function `try_new` is never used
--> src/error.rs:134:19
|
125 | impl WithStatusCode {
| ------------------- associated function in this implementation
...
134 | pub(crate) fn try_new(code: u16) -> Result<WithStatusCode> {
| ^^^^^^^
|
|
methods `is_unset`, `as_bytes`, and `as_bytes_unchecked` are never used:
src/config.rs#L99
warning: methods `is_unset`, `as_bytes`, and `as_bytes_unchecked` are never used
--> src/config.rs:99:19
|
94 | impl Setting {
| ------------ methods in this implementation
...
99 | pub(crate) fn is_unset(&self) -> bool {
| ^^^^^^^^
...
103 | pub(crate) fn as_bytes(&self) -> Option<&[u8]> {
| ^^^^^^^^
...
108 | pub(crate) fn as_bytes_unchecked(&self) -> &[u8] {
| ^^^^^^^^^^^^^^^^^^
|
|
function `set_setting` is never used:
src/config.rs#L70
warning: function `set_setting` is never used
--> src/config.rs:70:15
|
70 | pub(crate) fn set_setting<'e, 'q, T, E>(key: &'static str, value: T, executor: E) -> impl Future<Output = Result<()>> + 'q
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
artifact
Expired
|
24.6 MB |
|