Fix a couple glitchy quads #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hw prioritizes the earlier vertex instead of leftmost
nadiaholmquist
force-pushed
the
master
branch
from
10c70eb to
a7575ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some buggy quads rendering improperly.
The correct tie breaker for two points with the same y is to render the earlier vertex, rather than the leftmost one.
Doesn't seem to break anything from testing, and I don't think it should, since the only thing this impacts is Xtop (unused?), YTop (should be identical), and VTop (only used for determining which vertex to start rendering a polygon at)
I left the bottom check unchanged because i couldn't find any similar incorrect behavior with it, and I figured no reason to change what isn't broken.
Example of fix:
