Fix gdbstub not activating until the console is reset #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for initialising the gdbstub depending on whether the JIT was enabled or not was the wrong way around: previously, it would only enable the gdbstub if the JIT was enabled. The stub started working again if you reset the console, as NDS::SetGdbArgs didn't have any such check and it was called by EmuInstance::updateConsole.
|
Yeah that makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for initialising the gdbstub depending on whether the JIT was enabled or not was the wrong way around: previously, it would only enable the gdbstub if the JIT was enabled.
The stub started working again if you reset the console, as NDS::SetGdbArgs didn't have any such check and it was called by EmuInstance::updateConsole.