Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Nox #2865

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Bump Nox #2865

wants to merge 2 commits into from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 31, 2025

Summary by Sourcery

Upgrade Nox to the latest version, addressing issues with uvx and replay files, and improving dependency management.

Build:

  • Update the Noxfile to use uvx instead of uv tool run, simplifying command execution.

CI:

  • Update the cookiecutter E2E test workflow to include a new requirements file and trigger on changes to it.

📚 Documentation preview 📚: https://meltano-sdk--2865.org.readthedocs.build/en/2865/

Copy link
Contributor

sourcery-ai bot commented Jan 31, 2025

Reviewer's Guide by Sourcery

This PR updates the nox dependency to the latest version, which includes changes to how nox is invoked and how dependencies are loaded. It also updates the cookiecutter e2e workflow to include the requirements.txt file.

Flow diagram of updated Nox dependency changes

flowchart LR
    subgraph Before
        A1[nox.project.load_toml
with explicit path] --> B1[Load dependency groups]
        C1[uv tool run] --> D1[Execute tools
cookiecutter/twine/pre-commit]
    end
    subgraph After
        A2[nox.project.load_toml
without path] --> B2[Load dependency groups]
        C2[uvx] --> D2[Execute tools
cookiecutter/twine/pre-commit]
    end
    style Before fill:#f9f,stroke:#333
    style After fill:#9f9,stroke:#333
Loading

File-Level Changes

Change Details Files
Update nox dependency to the latest version.
  • Update nox dependency to the latest version from git.
  • Update uv invocations to uvx in noxfile.py.
  • Update nox options to be a tuple instead of a list.
  • Update nox project load to not include the file name.
noxfile.py
.github/workflows/resources/requirements.txt
Update cookiecutter e2e workflow to include the requirements.txt file.
  • Add requirements.txt to the list of files that trigger the cookiecutter e2e workflow.
.github/workflows/cookiecutter-e2e.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #2865 will not alter performance

Comparing edgarrmondragon/ci/bump-nox (4d690e2) with main (61c1413)

Summary

✅ 7 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch 2 times, most recently from 232bf4f to 40c91a5 Compare January 31, 2025 22:48
@edgarrmondragon edgarrmondragon self-assigned this Jan 31, 2025
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from 40c91a5 to 9ad5fb2 Compare January 31, 2025 22:49
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (61c1413) to head (4d690e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   91.37%   91.33%   -0.04%     
==========================================
  Files          62       62              
  Lines        5203     5203              
  Branches      675      675              
==========================================
- Hits         4754     4752       -2     
- Misses        317      319       +2     
  Partials      132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from 9ad5fb2 to e02f669 Compare January 31, 2025 23:30
@edgarrmondragon
Copy link
Collaborator Author

@sourcery-ai review

edgarrmondragon and others added 2 commits February 5, 2025 09:57
* chore: Require uv be used with Nox

* Use uv more broadly

* Move `UV_CONSTRAINT` to the top

* Remove redundant installation of griffe
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from e02f669 to 4d690e2 Compare February 5, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant