Update benchmarks #184

pgronkievitz · 2023-06-28T10:27:04Z

Some div IDs/names were changed and joining room via link is not using GET parameter anymore

Changes:

Update test URL - room name is now part of path instead of room_id GET parameter
Update selectors
1. Display name input occurs twice in the UI currently (although it's not displayed twice), now it's using xpath selector for the 2nd one
2. There's no submit type element, using join link

benchmarks/simple_mustang.ex

pgronkievitz requested a review from bblaszkow06 as a code owner June 28, 2023 10:27

bblaszkow06 suggested changes Jun 30, 2023

View reviewed changes

benchmarks/simple_mustang.ex Outdated Show resolved Hide resolved

pgronkievitz requested a review from bblaszkow06 July 19, 2023 10:04

bblaszkow06 requested a review from kamil-stasiak July 25, 2023 09:54

bblaszkow06 approved these changes Jul 25, 2023

View reviewed changes

pgronkievitz added 3 commits August 17, 2023 11:10

update input and button selectors

a541f8c

update room url to follow new format

05202d5

update div ids and playwright selectors

8b5ee04

pgronkievitz force-pushed the update-benchmarks branch from 0ff5f00 to 8b5ee04 Compare August 17, 2023 09:10

kamil-stasiak removed their request for review December 8, 2023 15:18

Provide feedback