-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WSL2 as a Firmware Development Environment #516
base: master
Are you sure you want to change the base?
feat: WSL2 as a Firmware Development Environment #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPHutchins This is an awesome article! I have a handful of questions and requests before we move to the next step.
It’s no surprise that WSL2 can do anything you need over the network, since one of its | ||
primary use cases is web development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about your common networking use cases to add some more content here. Probably ssh-ing into remote machines, transmitting data between local host ports, for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I added a few examples! Interestingly, when I'm working on traditional VMs I ended up needing to do more SSH and network share type things, but with WSL2 a lot of that is abstracted by the terminal or VSCode. In VSCode you can right click a file and "Download" it to your Windows host.
[usbipd-win](https://github.com/dorssel/usbipd-win) is | ||
[officially recommended by Microsoft](https://learn.microsoft.com/en-us/windows/wsl/connect-usb) | ||
and provides a stable foundation for USB forwarding including automatic attach | ||
by both port and device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be worth mentioning the requirements for usbipd-win -- a kernel version of 5.10.60.1 or greater, your call: https://github.com/dorssel/usbipd-win/wiki/WSL-support/6befeedd4c8e2a49468e4b03532c9a20478f8677
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tricky one, because I think that the USBIPD documentation is slightly out of date there. I've used USBIPD for at least two years. If someone has Windows 11, they're guaranteed to have a new enough WSL2, and Windows 10 is end of life soon.
I think that I need to specify use of Windows 11 🤔
I also compiled Kernel 6.1 and 6.6 for WSL2 and saw that Kernel 6.1 shrank the | ||
performance gap by about 4%. In my opinion, that's not worth it, but it shows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean 6.6 shrank the performance gap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I didn't record the 6.6 test. So the screen shot is indeed for 6.1, which I don't think MS will ever officially release since they're working on 6.6 now.
> Note: I made a few patches to improve Twister’s Windows support which is why | ||
a diff is shown in the prompt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the screen shot maybe cut off at the top? I don't see the diff you're referring to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
## Zephyr Benchmark | ||
|
||
<div class="mermaid"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mermaid chart is great! What do you think of moving it to the end of the section? Without context, seeing this first raises a bunch of questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
{% include toc.html %} | ||
|
||
## Features and Limitations | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a paragraph here introducing the section and your table?
The patches that were made were for better terminal compatibility, they wouldn't have impacted the test run.
@gminn Thanks for the detailed review! I closed a few the conversations where the change was pretty straightforward and left the others open. |
Original PR here: #515
Mermaid support is added, which is optionally enabled with
mermaid: true
at the top of an article.JP