fix: check that the update module is set in mender_download_artifact

Due to `artifact_read_data_prepare` not being called when an artifact doesn't have any files, the update module might be NULL after `mender_http_artifact_download` returns MENDER_OK. Add an explicit check to ensure this is caught. Changelog: None Ticket: MEN-7804 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
mendersoftware · Jan 30, 2025 · b4efb25 · b4efb25
1 parent f2acb52
commit b4efb25
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/core/src/mender-artifact-download.c b/core/src/mender-artifact-download.c
@@ -53,6 +53,12 @@ mender_download_artifact(const char *uri, mender_deployment_data_t *deployment_d
         return ret;
     }
 
+    /* If the artifact doesn't contain a file, the update module won't be set */
+    if (NULL == dl_data.update_module) {
+        mender_log_error("No Update Module detected - check that the artifact contains a file");
+        return MENDER_FAIL;
+    }
+
     /* Treatment depending of the status */
     if (200 == status) {
         /* Nothing to do */