-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: trigger mender-mcu-pipeline #140
ci: trigger mender-mcu-pipeline #140
Conversation
0da540b
to
2280a27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Let's get this working ASAP, please. :)
.gitlab-ci.yml
Outdated
@@ -4,8 +4,12 @@ include: | |||
- '.gitlab-ci-check-commits.yml' | |||
- '.gitlab-ci-github-status-updates.yml' | |||
|
|||
variables: | |||
MENDER_MCU_REVISION: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the PR revision here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup - that should be the only thing missing here
49426ee
to
d4b5192
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I fully understand the YAML magic, but looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestion below wrt mender-mcu-integration versioning
rules: | ||
- if: $CI_COMMIT_BRANCH =~ /^(pr_[0-9]+)/ | ||
variables: | ||
MENDER_MCU_REVISION: ${CI_EXTERNAL_PULL_REQUEST_SOURCE_BRANCH_SHA} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL 🎉 Thank you
a664c41
to
66e685e
Compare
66e685e
to
7b62de8
Compare
Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
7b62de8
to
3e4c175
Compare
No description provided.