Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: trigger mender-mcu-pipeline #140

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

danielskinstad
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Let's get this working ASAP, please. :)

.gitlab-ci.yml Outdated
@@ -4,8 +4,12 @@ include:
- '.gitlab-ci-check-commits.yml'
- '.gitlab-ci-github-status-updates.yml'

variables:
MENDER_MCU_REVISION: main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the PR revision here, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - that should be the only thing missing here

@danielskinstad danielskinstad force-pushed the test-trigger branch 8 times, most recently from 49426ee to d4b5192 Compare February 3, 2025 13:23
@danielskinstad danielskinstad changed the title test ci: trigger mender-mcu-pipeline Feb 3, 2025
Copy link
Collaborator

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I fully understand the YAML magic, but looks good to me.

Copy link
Collaborator

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion below wrt mender-mcu-integration versioning

rules:
- if: $CI_COMMIT_BRANCH =~ /^(pr_[0-9]+)/
variables:
MENDER_MCU_REVISION: ${CI_EXTERNAL_PULL_REQUEST_SOURCE_BRANCH_SHA}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 🎉 Thank you

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
@danielskinstad danielskinstad force-pushed the test-trigger branch 3 times, most recently from a664c41 to 66e685e Compare February 4, 2025 12:26
.gitlab-ci.yml Outdated Show resolved Hide resolved
Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
@danielskinstad danielskinstad merged commit b65c847 into mendersoftware:main Feb 4, 2025
2 checks passed
@danielskinstad danielskinstad deleted the test-trigger branch February 4, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants