Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-7169 - feat: added multi sorting capabilities to devices view #9

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mzedel
Copy link
Contributor

@mzedel mzedel commented Sep 2, 2024

No description provided.

@mzedel mzedel requested review from michaelntech and olehermanse and removed request for olehermanse September 2, 2024 11:24
…init interactions

Ticket: None
Changelog: None
Signed-off-by: Manuel Zedel <[email protected]>
…ort asc/desc/none sorting

Signed-off-by: Manuel Zedel <[email protected]>
Ticket: MEN-7169
Changelog: None
Signed-off-by: Manuel Zedel <[email protected]>
+ made alternative data table work with multi sorting data to help work with sorting info from url state

Ticket: MEN-7169
Changelog: Title
Signed-off-by: Manuel Zedel <[email protected]>
@mender-test-bot
Copy link
Contributor

mender-test-bot commented Sep 27, 2024

Merging these commits will result in the following changelog entries:

Changelogs

mender-server (men-7169)

New changes in mender-server since main:

Features
  • added multi sorting capabilities to devices view
    (MEN-7169)

Copy link
Contributor

@aleksandrychev aleksandrychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@michaelntech michaelntech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is still missing some visual indicators to show the user what the current sorting is and how to escape it/start a new sort – just by clicking on columns, I get a bit lost and can't revert back a simple sort on one column. Will try to provide some UX design so it can be incorporated to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants