Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry 5.0.x]: fix: retry polling on all errors #1733

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

mender-test-bot
Copy link

Cherry pick of PR: #1730
For you :)

When implementing the backoff for errors when polling for deployment or
submitting inventory, we added an exception for unauthorized errors.
After looking at how it was done in Mender Client 3, we discovered
that such an exception was not present there, and that the backoff
should be triggered for all types of errors.

Changelog: All errors on attempts to communicate with the server
are retried with an exponential backoff. This aligns the behavior
of the state machine with Mender Client 3.

Ticket: MEN-7938

Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
(cherry picked from commit 45f88a1)
@mender-test-bot
Copy link
Author

mender-test-bot commented Jan 24, 2025

Merging these commits will result in the following changelog entries:

Changelogs

mender (cherry-5.0.x-retry-mechanism-fix)

New changes in mender since 5.0.x:

Bug Fixes
  • All errors on attempts to communicate with the server
    are retried with an exponential backoff. This aligns the behavior
    of the state machine with Mender Client 3.
    (MEN-7938)

@danielskinstad
Copy link
Contributor

@mender-test-bot start pipeline

@mender-test-bot
Copy link
Author

@mender-test-bot, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline".


my commands and options

You can trigger a pipeline on multiple prs with:

  • mentioning me and start pipeline --pr mender/127 --pr mender-connect/255

You can start a fast pipeline, disabling full integration tests with:

  • mentioning me and start pipeline --fast

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@mender-test-bot
Copy link
Author

Hello 😺 I created a pipeline for you here: Pipeline-1639745553

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
INTEGRATION_REV 3.8.x
MENDER_BINARY_DELTA_REV 1.5.x
MENDER_CONFIGURE_MODULE_REV 1.1.x
MENDER_CONNECT_REV 2.3.x
MENDER_GATEWAY_REV 2.0.x
MENDER_REV pull/1733/head
META_MENDER_REV kirkstone
META_OPENEMBEDDED_REV kirkstone
META_RASPBERRYPI_REV kirkstone
MONITOR_CLIENT_REV 1.4.x
POKY_REV kirkstone
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@danielskinstad
Copy link
Contributor

@lluiscampos you can merge this whenever you want

@lluiscampos lluiscampos merged commit 80c9aae into 5.0.x Jan 26, 2025
16 checks passed
@lluiscampos lluiscampos deleted the cherry-5.0.x-retry-mechanism-fix branch January 26, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants