Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RTCP tables to appendix and reference section 8 #120

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

mengelbart
Copy link
Owner

No description provided.

Generic *Negative Acknowledgments* (`PT=205`, `FMT=1`, `Name=Generic NACK`,
{{!RFC4585}}) contain information about RTP packets which the receiver
considered lost. {{Section 6.2.1. of !RFC4585}} recommends to use this feature
only, if the underlying protocol cannot provide similar feedback. QUIC does not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considered lost. {{Section 6.2.1. of !RFC4585}} recommends to use this feature
only, if the underlying protocol cannot provide similar feedback. QUIC does not

I'd suggest "only if" here.

*Extended Reports* (`PT=207`, `Name=XR`, {{!RFC3611}}) offer an extensible
framework for a variety of different control messages. Some of the standard
report blocks which can be implemented in extended reports can be implemented in
QUIC, too. Other report blocks need to be evaluated individually, to determine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the standard
report blocks which can be implemented in extended reports can be implemented in
QUIC, too.

I'm not sure if "standard report blocks" is the right term here. ("Standard" has so many meanings in IETF specifications!)

Is this saying

Some of the statistics that are defined as extended report blocks can be derived from QUIC, too.

considered lost. {{Section 6.2.1. of !RFC4585}} recommends to use this feature
only, if the underlying protocol cannot provide similar feedback. QUIC does not
provide negative acknowledgments, but can detect lost packets based on the Gap
numbers contained in QUIC ACK frames {{Section 6 of !RFC9002}}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest enclosing {{Section 6 of !RFC9002}} in parentheses, as "({{Section 6 of !RFC9002}})."


Several but not all of these control packets and their attributes can be mapped
from QUIC, as described in {{transport-layer-feedback}}. *Mappable from QUIC*
has one of three values: *yes*, *QUIC extension required*, and *no*.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things for this text:

Several but not all of these control packets and their attributes can be mapped
from QUIC, as described in {{transport-layer-feedback}}. Mappable from QUIC
has one of three values: yes, QUIC extension required, and no.

I THINK this paragraph applies to more subsections than ## RTCP Control Packet Types {#control-packets}.

Also, I'm also seeing partly and possibly in this section, but I'm not seeing QUIC extension required.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I moved the paragraph to the section introduction so it applies to all the following subsections. I also replaced QUIC extension required with possibly and partly, including short explanations and updated the table values to match their respective descriptions.

@mengelbart mengelbart merged commit 40be8b6 into main Sep 22, 2023
2 checks passed
@mengelbart mengelbart deleted the fix/80-rtcp-tables-appendix branch September 22, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carrying SR NTP Timestamps at QUIC layer Reference RTCP subsections from tables
2 participants