-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BYE to CONNECTION_CLOSE mapping considerations #132
Conversation
58717bb
to
3ce3b74
Compare
draft-ietf-avtcore-rtp-over-quic.md
Outdated
transmitted in QUIC's CONNECTION_CLOSE *Reason Phrase*. However, if the | ||
participants only wish to leave one RTP session while continuing to use the QUIC | ||
connection for other data streams, a CONNECTION_CLOSE cannot be used, as it | ||
would close the QUIC connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest rephrasing this sentence as
However, if the
participant only wishes to leave one RTP session while continuing to use the QUIC
connection, the BYE packet MUST be used, because the QUIC CONNECTION_CLOSE
would close the entire QUIC connection for all other QUIC streams and datagrams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to avoid the normative MUST in the BYE packet MUST be used, because that is not a requirement of RFC 3550 in the first place (A participant [...] MAY leave the group without sending a BYE at all.). How about this:
However, if the
participant only wishes to leave one RTP session while continuing to use the QUIC
connection, it has to use the BYE packet because the QUIC CONNECTION_CLOSE
would close the entire QUIC connection for all other QUIC streams and datagrams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mengelbart - we're getting close to converging.
The point I was struggling with, is that if you don't send a BYE packet, the sender would continue to send RTP media until the sender detects that the receiver is no longer sending RRs, and "times the receiver out". I agree with you, that inserting a MUST is adding a requirement that isn't in RTP today, so I guess the assumption is that the receiver has some reason for not using BYE, and I shouldn't complain about that.
I do think it's worth pointing out that we're allowing multiplexing of RTP/RTCP and other protocols in a single QUIC connection, so maybe it's better to also allow for the case where the participant is leaving the RTP session, but is continuing to use the QUIC connection for "something else", by saying something like
However, if the
participant wishes to use this QUIC
connection for any other multiplexed traffic, the participant has to use the BYE packet because the QUIC CONNECTION_CLOSE
would close the entire QUIC connection for all other QUIC streams and datagrams.
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. I updated the PR with your proposal and will merge it now.
3ce3b74
to
9cbb319
Compare
No description provided.