Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to resume sending datagrams after STOP_SENDING #139

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mengelbart
Copy link
Owner

No description provided.

Copy link
Collaborator

@joerg-ott joerg-ott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or as datagram(s)?

Copy link
Collaborator

@SpencerDawkins SpencerDawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning datagrams within the section discussing STOP_SENDING seems confusing, because this is in Section 5.2 (streams), and because datagrams aren't associated with a stream, STOP_SENDING and RESET_STREAM won't have any effect on whether the sender continues to send datagrams.

If you want to say the same kind of thing about datagrams that we're saying here about streams ("don't re-send old media"), I guess we can say that in Section 5.3, but I'm not sure I understand why we need to say anything.

But I'm not sure what you're trying to get at, with this change. I might guess, but I'd be guessing. HELP! 😶

(Ping me on Slack if we need to talk, please!)

@mengelbart
Copy link
Owner Author

The problem I see is with this sentence:

the RoQ sender MUST open one or more new QUIC streams before sending new media frames.

To me, this sounds like I definitely MUST continue sending new media on new streams. But I might want to continue sending the subsequent frames as datagrams instead (and never open a new QUIC stream again). We might instead add something like STOP_SENDING is not a request to end the media stream but only an indication that a receiver stopped reading a media frame. A sender SHOULD continue sending new media frames of the same media stream. New media frames can be sent in new QUIC streams or as QUIC datagrams (see section ...).

I'm using SHOULD here because the sender may decide to stop the media stream for different reasons.

@SpencerDawkins
Copy link
Collaborator

SpencerDawkins commented Oct 15, 2023

@mengelbart - we're converging. I have a somewhat different suggestion, but I agree with where you're going with this text.

STOP_SENDING is not a request to the sender to stop sending the RTP media stream, only an indication that a receiver stopped reading the QUIC stream being used. A sender with additional media frames to send SHOULD continue sending them on a QUIC stream in the "Ready" state. Alternatively, new media frames can be sent as QUIC datagrams (see section ...).

Does that make sense?

@mengelbart mengelbart force-pushed the fix/136-stop-sending-continue-datagrams branch from a2ac4fe to 47c4d1e Compare October 16, 2023 13:22
@mengelbart
Copy link
Owner Author

STOP_SENDING is not a request to the sender to stop sending the RTP media stream, only an indication that a receiver stopped reading the QUIC stream being used. A sender with additional media frames to send SHOULD continue sending them on a QUIC stream in the "Ready" state. Alternatively, new media frames can be sent as QUIC datagrams (see section ...).

I updated the PR, but instead of a QUIC stream in the "Ready" state, I used another QUIC stream, which is closer to how it was before the change because the Ready state is only one of the possible states described in RFC9000. I think it could also be in the Send state if the other QUIC stream was used for other packets before.

@SpencerDawkins
Copy link
Collaborator

Hi, @mengelbart - I think we're converged here (on your text). I was hoping I would be able to qualify "another QUIC stream", but after reflection, I don't think that's necessary or helpful.

Dude - merge it!

@mengelbart mengelbart merged commit 0b580e7 into main Oct 16, 2023
2 checks passed
@mengelbart mengelbart deleted the fix/136-stop-sending-continue-datagrams branch October 16, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to continue sending media on QUIC datagrams after receiving STOP_SENDING
3 participants