-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to resume sending datagrams after STOP_SENDING #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or as datagram(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioning datagrams within the section discussing STOP_SENDING seems confusing, because this is in Section 5.2 (streams), and because datagrams aren't associated with a stream, STOP_SENDING and RESET_STREAM won't have any effect on whether the sender continues to send datagrams.
If you want to say the same kind of thing about datagrams that we're saying here about streams ("don't re-send old media"), I guess we can say that in Section 5.3, but I'm not sure I understand why we need to say anything.
But I'm not sure what you're trying to get at, with this change. I might guess, but I'd be guessing. HELP! 😶
(Ping me on Slack if we need to talk, please!)
The problem I see is with this sentence:
To me, this sounds like I definitely MUST continue sending new media on new streams. But I might want to continue sending the subsequent frames as datagrams instead (and never open a new QUIC stream again). We might instead add something like STOP_SENDING is not a request to end the media stream but only an indication that a receiver stopped reading a media frame. A sender SHOULD continue sending new media frames of the same media stream. New media frames can be sent in new QUIC streams or as QUIC datagrams (see section ...). I'm using SHOULD here because the sender may decide to stop the media stream for different reasons. |
@mengelbart - we're converging. I have a somewhat different suggestion, but I agree with where you're going with this text.
Does that make sense? |
a2ac4fe
to
47c4d1e
Compare
I updated the PR, but instead of |
Hi, @mengelbart - I think we're converged here (on your text). I was hoping I would be able to qualify "another QUIC stream", but after reflection, I don't think that's necessary or helpful. Dude - merge it! |
No description provided.