-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure streams #143
Configure streams #143
Conversation
draft-ietf-avtcore-rtp-over-quic.md
Outdated
To send RTP/RTCP packets over QUIC streams, a sender MUST open a | ||
new unidirectional QUIC stream. Streams are unidirectional because there is no | ||
To send RTP/RTCP packets over QUIC streams, a sender MUST open at least one new unidirectional QUIC stream. | ||
In order to permit QUIC streams to open, a RoQ sender SHOULD configure non-zero minimum values for the number of permitted streams and the initial stream flow-control window, based on the number of parallel, or simultaneously active, RTP/RTCP flows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful addition, but I suggest moving it into the MAX_STREAMS/flow control subsection to keep all the things related to that issue in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed (thanks for the helpful suggestion). I committed a change for this.
@mengelbart - I'm looking at this text, also in {#quic-streams},
I think this would be better as
I'm not wild about
for a couple of reasons. Is this more like
We can wait to talk about the SHOULD until we work on #111, but in any event,
If you send me an RTP packet with sequence number 12 on stream 32, and I'm not prepared to accept it. Do I drop it? Do I need to tell you that I'm dropping it because of the stream it arrived on, so you don't look at the ACKs/RRs and decide that you need to reduce the sending rate (because you're sending RTP packets that aren't being acknowledged)? Etc. |
Sounds good to me.
These are good points. I think we want to use MUST instead. There should be no special treatment of RTP packets just because they arrive on a stream with a lower ID or on datagrams. |
closes #142