Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure streams #143

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Configure streams #143

merged 3 commits into from
Oct 23, 2023

Conversation

SpencerDawkins
Copy link
Collaborator

@SpencerDawkins SpencerDawkins commented Oct 18, 2023

closes #142

To send RTP/RTCP packets over QUIC streams, a sender MUST open a
new unidirectional QUIC stream. Streams are unidirectional because there is no
To send RTP/RTCP packets over QUIC streams, a sender MUST open at least one new unidirectional QUIC stream.
In order to permit QUIC streams to open, a RoQ sender SHOULD configure non-zero minimum values for the number of permitted streams and the initial stream flow-control window, based on the number of parallel, or simultaneously active, RTP/RTCP flows.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful addition, but I suggest moving it into the MAX_STREAMS/flow control subsection to keep all the things related to that issue in one place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed (thanks for the helpful suggestion). I committed a change for this.

@SpencerDawkins
Copy link
Collaborator Author

@mengelbart - I'm looking at this text, also in {#quic-streams},

A RoQ receiver MUST be prepared to receive RTP packets on any number of QUIC streams (subject to its limit on parallel open streams) and SHOULD not make assumptions about which RTP sequence numbers are carried in which streams.

Note: A sender may or may not decide to discontinue using a lower stream number after starting packet transmission on a higher stream number.

I think this would be better as

Because a sender can continue sending on a lower stream number after starting packet transmission on a higher stream number, a RoQ receiver MUST be prepared to receive RoQ packets on any number of QUIC streams (subject to its limit on parallel open streams) and SHOULD not make assumptions about which RTP sequence numbers are carried in which streams.

I'm not wild about

SHOULD not make assumptions about which RTP sequence numbers are carried in which streams

for a couple of reasons.

Is this more like

SHOULD be prepared to accept any RTP sequence number on any open stream?

We can wait to talk about the SHOULD until we work on #111, but in any event,

  • we should have a legitimate reason for why a RoQ receiver would choose not to accept any RTP sequence number on any open stream, given that a RoQ sender can send any RTP sequence number on any open stream, and
  • if a RoQ receiver makes that choice, we need to think about what happens next.

If you send me an RTP packet with sequence number 12 on stream 32, and I'm not prepared to accept it. Do I drop it? Do I need to tell you that I'm dropping it because of the stream it arrived on, so you don't look at the ACKs/RRs and decide that you need to reduce the sending rate (because you're sending RTP packets that aren't being acknowledged)? Etc.

@mengelbart
Copy link
Owner

@mengelbart - I'm looking at this text, also in {#quic-streams},

A RoQ receiver MUST be prepared to receive RTP packets on any number of QUIC streams (subject to its limit on parallel open streams) and SHOULD not make assumptions about which RTP sequence numbers are carried in which streams.
Note: A sender may or may not decide to discontinue using a lower stream number after starting packet transmission on a higher stream number.

I think this would be better as

Because a sender can continue sending on a lower stream number after starting packet transmission on a higher stream number, a RoQ receiver MUST be prepared to receive RoQ packets on any number of QUIC streams (subject to its limit on parallel open streams) and SHOULD not make assumptions about which RTP sequence numbers are carried in which streams.

Sounds good to me.

I'm not wild about

SHOULD not make assumptions about which RTP sequence numbers are carried in which streams

for a couple of reasons.

Is this more like

SHOULD be prepared to accept any RTP sequence number on any open stream?

We can wait to talk about the SHOULD until we work on #111, but in any event,

* we should have a legitimate reason for why a RoQ receiver would choose not to accept any RTP sequence number on any open stream, given that a RoQ sender can send any RTP sequence number on any open stream, and

* if a RoQ receiver makes that choice, we need to think about what happens next.

If you send me an RTP packet with sequence number 12 on stream 32, and I'm not prepared to accept it. Do I drop it? Do I need to tell you that I'm dropping it because of the stream it arrived on, so you don't look at the ACKs/RRs and decide that you need to reduce the sending rate (because you're sending RTP packets that aren't being acknowledged)? Etc.

These are good points. I think we want to use MUST instead. There should be no special treatment of RTP packets just because they arrive on a stream with a lower ID or on datagrams.

@mengelbart mengelbart merged commit 5ed8189 into main Oct 23, 2023
2 checks passed
@mengelbart mengelbart deleted the issue-142-configure-streams branch October 23, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text for configuring unidirectional RoQ streams
2 participants