-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KAN-39] Review 작성 API & 테스트코드 초안 작성 #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코틀린 처음이시라 어려우셨을텐데 고생많으셨습니다 👍 👍 리뷰 내용 한번씩 확인 부탁드리고 아래 확인 사항도 체크 부탁드립니다.
- KAN-25가 맞나요? 확인해서 PR명 + 커밋명 고치면 좋을 것 같아요.
- ktlint도 고쳐주세요~
src/main/kotlin/com/restaurant/be/review/domain/service/CreateReviewService.kt
Show resolved
Hide resolved
src/main/kotlin/com/restaurant/be/review/presentation/dto/CreateReviewDto.kt
Show resolved
Hide resolved
src/main/kotlin/com/restaurant/be/review/presentation/dto/common/ReviewDto.kt
Show resolved
Hide resolved
src/main/kotlin/com/restaurant/be/review/presentation/dto/common/ReviewDto.kt
Show resolved
Hide resolved
goathoon
changed the title
[Kan-25] Review 작성 API & 테스트코드 초안 작성
[KAN-39] Review 작성 API & 테스트코드 초안 작성
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
테스트코드는 flow 익히는 용으로 간단히 작성했씁니다.
Type Checking을 400으로 반환하게하고싶었는데 일단 급해서 500으로하고 올려요