Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KAN-39] Review 작성 API & 테스트코드 초안 작성 #31

Closed
wants to merge 8 commits into from

Conversation

goathoon
Copy link
Member

테스트코드는 flow 익히는 용으로 간단히 작성했씁니다.
Type Checking을 400으로 반환하게하고싶었는데 일단 급해서 500으로하고 올려요

Copy link
Member

@sinkyoungdeok sinkyoungdeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코틀린 처음이시라 어려우셨을텐데 고생많으셨습니다 👍 👍 리뷰 내용 한번씩 확인 부탁드리고 아래 확인 사항도 체크 부탁드립니다.

  • KAN-25가 맞나요? 확인해서 PR명 + 커밋명 고치면 좋을 것 같아요.
  • ktlint도 고쳐주세요~

@goathoon goathoon changed the title [Kan-25] Review 작성 API & 테스트코드 초안 작성 [KAN-39] Review 작성 API & 테스트코드 초안 작성 May 12, 2024
@goathoon goathoon closed this May 12, 2024
@sinkyoungdeok sinkyoungdeok deleted the KAN-25 branch May 25, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants