chore: update dev dependencies #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernscht
requested changes
Dec 1, 2023
package.json
Outdated
| }, | ||
| "engines": { | ||
| "node": ">=14.15.0" | ||
| "node": ">=16.20.0" |
There was a problem hiding this comment.
This is a breaking change and must not be hidden in a dev dependencies update.
What are we doing?
webpack.config.js
Outdated
| }, | ||
| plugins: [ | ||
| // Cleans the dist folder before the build starts | ||
| new CleanWebpackPlugin(), | ||
| // Multi threading typescript loader configuration with caching for .ts and .tsx files | ||
| // see https://github.com/merkle-open/webpack-config-plugins/tree/master/packages/ts-config-webpack-plugin/config | ||
| new TsConfigWebpackPlugin(), | ||
| new TsConfigWebpackPlugin() |
There was a problem hiding this comment.
These kinds of changes should not be made. Please prettify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request we update all dependencies that are not a ESM version. Further more we lift the development version to node 18 and ensure node 20 support in the GH pipeline.