Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example added: Graph Input from User #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amanchhaparia
Copy link
Collaborator

@amanchhaparia amanchhaparia commented Jun 19, 2022

This PR intends to add an example to take a graph input from user.

Copy link
Owner

@meshtag meshtag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!
What I had in mind for initial design was a comprehensive C++ interface which can accept graphs in all general ways supported by a uniform generic backend which will be used/handled generically in all lowering passes (graph algorithms) of graph dialect.

Feel free to express your ideas about the generic backend capable of all possible interconversions from the C++ user interface.

@amanchhaparia
Copy link
Collaborator Author

amanchhaparia commented Jun 20, 2022

Understood your implementation strategy @meshtag!
As a initial impression in my mind I think we can interconvert the graphs into adjacency matrix ie in 2D matrix and can convert it to 1D array as required by the MemRef backend, also it will provide a easy access of the elements while implementing our graph algorithms but its downside is maybe that it is not the most space efficient way.

@meshtag
Copy link
Owner

meshtag commented Jun 20, 2022

Can you please provide some basic code snippets to make sure we are on the same page.

@meshtag
Copy link
Owner

meshtag commented Feb 26, 2023

What is the status of this PR? @amanchhaparia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants