Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traceroute back route display to handle case where route back is not valid #1046

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

bjpetit
Copy link
Contributor

@bjpetit bjpetit commented Jan 8, 2025

What changed?

Fixed issue where traceroute info wasn't saved if route back wasn't valid.
Update route back handling to display "unknown" when the route back info is not valid.

Why did it change?

Looks like the traceroute data could get dropped if the route back isn't valid. With that fixed, the route back could display "Direct" when the route back data is invalid which is incorrect.

Looking for feedback. The other option is that we just drop references to back messages. But I thought this was a little more clear that the route back data is invalid.

How is this tested?

Ran various traceroutes and validated the data. I. don't have a setup that will return invalid route back info, so I tested that by artificially dropping the route back processing.

Screenshots/Videos (when applicable)

Here's an example of what the message will look like if the route back data is invalid.
Screenshot 2025-01-08 at 09 16 23 jpeg

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@bjpetit bjpetit mentioned this pull request Jan 8, 2025
5 tasks
@GUVWAF
Copy link
Member

GUVWAF commented Jan 8, 2025

Great. "unknown" sounds good to me, then it's clear the data is missing.

@garthvh garthvh changed the base branch from main to 2.5.15 January 11, 2025 15:59
@garthvh garthvh merged commit 2e5c1e3 into meshtastic:2.5.15 Jan 11, 2025
2 checks passed
@bjpetit bjpetit deleted the tr-back-update branch January 13, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants