Update traceroute back route display to handle case where route back is not valid #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed issue where traceroute info wasn't saved if route back wasn't valid.
Update route back handling to display "unknown" when the route back info is not valid.
Why did it change?
Looks like the traceroute data could get dropped if the route back isn't valid. With that fixed, the route back could display "Direct" when the route back data is invalid which is incorrect.
Looking for feedback. The other option is that we just drop references to back messages. But I thought this was a little more clear that the route back data is invalid.
How is this tested?
Ran various traceroutes and validated the data. I. don't have a setup that will return invalid route back info, so I tested that by artificially dropping the route back processing.
Screenshots/Videos (when applicable)
Here's an example of what the message will look like if the route back data is invalid.
Checklist