Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications fix #1069

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Notifications fix #1069

merged 10 commits into from
Jan 27, 2025

Conversation

RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Jan 22, 2025

What changed?

Make notifications instantly schedule instead of 1 second after.

Why did it change?

Work better with the notifications API as this should be done instantly.

How is this tested?

Tested on iPhone and watch.

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@RCGV1
Copy link
Member Author

RCGV1 commented Jan 22, 2025

I need to get rid of changes I made in meshpacket file

@RCGV1 RCGV1 marked this pull request as draft January 22, 2025 20:14
@RCGV1 RCGV1 marked this pull request as ready for review January 22, 2025 20:20
@RCGV1 RCGV1 requested a review from garthvh January 25, 2025 06:50
@garthvh garthvh changed the base branch from main to 2.5.18 January 27, 2025 21:04
Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@garthvh garthvh merged commit 11531ed into 2.5.18 Jan 27, 2025
2 checks passed
@garthvh garthvh deleted the notificationsFix branch January 27, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants