Rework ColorParams internals and allow conversion from fz_color_params
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginnyTheCat
changed the title
ColorParams internals and allow conversion back to fz_color_paramsColorParams internals and allow conversion from fz_color_params
messense
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shrinks
ColorParamssize from ani32down to au8using a bitflag approach. Imagining the u8 byte as a array of bits the layout looks like this:[0, 0, 0, opm, op, bp, ri, ri].This also implements
From<fz_color_params>and adds a Debug implementation that displays theColorParamsas a struct:ColorParams { rendering_intent: Saturation, bp: true, op: false, opm: false }for the result ofColorParams::new(RenderingIntent::Saturation, true, false, false).