-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to write Device
s in Rust
#105
Conversation
abe3fc7
to
2273ad7
Compare
Are you interested in any sort of help for this feature? I'm also very interested in being able to write devices in rust, so I'd like to help push this through if possible :) |
The branch is already usable, i just need to finish implement all methods. I'm also not sure what the best name is (atm I called the trait I will probably finish this PR on Monday. |
2273ad7
to
43dcade
Compare
ff52928
to
b18b50c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. It's a bit annoying that every device-related function has to be sort of duplicated 3-4 times, but I can't really see a way around it.
My main annoyance is that Rust doesn't provide a way to implement Especially as this is a quite common pattern. |
b18b50c
to
6dfc28d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This allows creating
Device
s in Rust by implementing theNativeDevice
trait and calling theDevice::from_native()
function.