Fix panics for invalid utf-8 json streams #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stext_page_as_json_from_page` was using `unwrap` for reading the mupdf json stream. This was causing panic when the stream was not a valid utf-8. The function now returns the `error` in such cases.
messense
approved these changes
Feb 21, 2025
|
Hey @messense, can you please release a new version? There have been many important improvements since last version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stext_page_as_json_from_pagewas usingunwrapfor reading the mupdf json stream. This was causing panic when the stream was not a valid utf-8.The function now returns the
errorin such cases.I have added the tests and the PDF where this error occurs.