Remove audit fix during docker build #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeyn
previously approved these changes
Aug 5, 2024
haarg
force-pushed
the
haarg/no-audit-fix
branch
from
3c14402 to
1c9cbe7
Compare
Doing an audit fix during docker build makes the output more unpredictable. And we have dependabot in place to update the listed dependencies. It also will cause errors for dependencies that it can't fix. We are using an older version of bootstrap, which has a XSS issue in it. But it doesn't impact us based on our use of bootstrap. We can't upgrade bootstrap without significant work, so for now we want to ignore this issue. npm audit doesn't provide any way to ignore specific dependencies.
haarg
force-pushed
the
haarg/no-audit-fix
branch
from
1c9cbe7 to
cde91e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing an audit fix during docker build makes the output more unpredictable. And we have dependabot in place to update the listed dependencies.
It also will cause errors for dependencies that it can't fix. We are using an older version of bootstrap, which has a XSS issue in it. But it doesn't impact us based on our use of bootstrap. We can't upgrade bootstrap without significant work, so for now we want to ignore this issue. npm audit doesn't provide any way to ignore specific dependencies.