Add SitemapReader originally developed in OERSI #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reads sitemap from URL, sends each `loc` URL to the receiver. e.g. `"https://hoou.de/sitemap.xml" | read-sitemap | open-http ...` in a Flux workflow to process every document linked in the sitemap. Supports paging via `from=` query string parameter (see #464) See: https://en.wikipedia.org/wiki/Sitemaps https://gitlab.com/oersi/oersi-etl/-/issues/4 https://gitlab.com/oersi/oersi-etl/-/issues/17
dr0i
approved these changes
Sep 23, 2022
|
Discussed in our planning meeting: we're putting this on hold to investigate if we actually need this kind of specific module for reading sitemaps, or if we can build something based on existing modules and the upcoming paging support (#464). |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads sitemap from URL, sends each
locURL to the receiver.e.g.
"https://hoou.de/sitemap.xml" | read-sitemap | open-http ...in a Flux workflow to process every document linked in the sitemap.Supports paging via
from=query string parameter in the sitemap URL.Assigning @dr0i for code review due to the (albeit loose) paging relation to #464.
We don't have a dedicated issue for this, maybe @TobiasNx could do functional review here?