Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround to link to Java Code #352

Merged
merged 2 commits into from
May 22, 2024

Conversation

TobiasNx
Copy link
Collaborator

@TobiasNx TobiasNx commented May 21, 2024

Since all fixes are in one of three Java Classes I created a workaround to link to the Java Code using the GitHub search.

@maipet could you have a look if this meets your demands?
@blackwinter could you have a look if this is okay for you?

Since all fixes are in one of three Java Classes I created a workaround to link to the Java Code using the GitHub search.
@TobiasNx TobiasNx requested a review from blackwinter May 21, 2024 14:31
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the idea itself, but I think the links could be improved.

README.md Outdated Show resolved Hide resolved
@TobiasNx TobiasNx requested a review from blackwinter May 21, 2024 15:11
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TobiasNx
Copy link
Collaborator Author

@maipet said that the need for double clicking to get to the code is confusing.
Unfortunatly github does not provide a search that links abstractly to a java class/method and I provided a workaround.

We will test and see if the workaround is sufficient for now.

@TobiasNx TobiasNx merged commit 747c4ce into master May 22, 2024
1 check passed
@TobiasNx TobiasNx deleted the Add-link-to-java-code-in-documentation branch May 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants