Optionally specify limit for number of entities in a record. #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proof-of-concept to gauge interest in such a feature; the immediate need has been rendered moot (due to the record's holdings being suppressed from publishing now).
This is a brute-force approach to dealing with OOM situations when Alma records have an excessive number of items (e.g. 99374518570506441: >12000 entities = ~10 GB heap for the Record instance). Loosely modeled after JAXP's
totalEntitySizeLimit
, except that we don't abort processing but instead skip the remaining entities.Use Metafix instance setter
setMaxEntityCount(int)
or set system propertyorg.metafacture.metafix.maxEntityCount=<int>
.Alternative options:
Possible optimizations (implemented in dc4f1af):
static final
; this way the JVM can (potentially) eliminate the check altogether when no limit has been set (less than zero).literal()
.