Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENSToken added #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ENSToken added #43

wants to merge 2 commits into from

Conversation

dijkstra-dev
Copy link

Please let me know if there's any problem with this PR. Thank you!

@height
Copy link

height bot commented Sep 8, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

@BrennerSpear BrennerSpear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment regarding the multi-sidedness of one of the functions. Please check the the other functions in case they are also multi-sided and need interpretations for each side.

Please also run the tests so that the snapshot files get updated

}
}
},
"transfer": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tokens get transferred, the delegate gets changed too. We need an interpretation for that action also,

There's a section in the contribution docs regarding "multi-sided transaction"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants