Configuring auditing with timescaledb. #217
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
vknabel
reviewed
Feb 6, 2025
| @@ -18,7 +18,7 @@ | |||
| tags: ipam-db | |||
| - name: metal-roles/control-plane/roles/masterdata-db | |||
| tags: masterdata-db | |||
| - name: metal-roles/control-plane/roles/auditing-meili | |||
| - name: metal-roles/control-plane/roles/auditing-timescaledb | |||
There was a problem hiding this comment.
it's not possible to toggle this role depending on a value switch like an environment variable, right?
If not: I think it would make sense for the mini-lab to include both backends for the mini-lab.
There was a problem hiding this comment.
It's now possible to use both backends. By default it's TimescaleDB, but backends can be toggled using the variables metal_auditing_timescaledb_enabled and metal_auditing_meili_enabled.
There was a problem hiding this comment.
I really vote for only one backend, we should simplify not complicate things. If we are not convinced with the existing solution we should get rid of it completely. Same applies for the extra code in the metal-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References: