Skip to content

Commit

Permalink
don't return an error and fail b/c there was no bios config to publish (
Browse files Browse the repository at this point in the history
  • Loading branch information
DoctorVin authored Jan 22, 2024
1 parent 35db8dd commit 02f371c
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions internal/store/serverservice/serverservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,14 @@ func (r *Store) AssetUpdate(ctx context.Context, asset *model.Asset) error {
}

func (r *Store) publishBiosConfig(ctx context.Context, asset *model.Asset, server *serverserviceapi.Server) error {
// Don't publish bios config if there's no bios config data made avai
// Nothing to publish
if len(asset.BiosConfig) == 0 {
errNoBiosConfig := errors.New("no BIOS configuration collected")
return errNoBiosConfig
r.logger.WithFields(logrus.Fields{
"vendor": asset.Vendor,
"model": asset.Model,
"serial": asset.Serial,
}).Info("no bios configuration collected")
return nil
}

if asset.HasError(outofband.GetBiosConfigError) {
Expand Down

0 comments on commit 02f371c

Please sign in to comment.