main: Exit if input files are not named pipes. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,23 @@ | |||
| package common | |||
Check warning
Code scanning / Revive (reported by Codacy)
should have a package comment Warning
In discussions with the team, we decided that the input files will always be named pipes. As a result, we felt it was necessary to enforce a file-type check that produces a helpful error message.
stephen-fox
force-pushed
the
check-inputs-file-type
branch
from
c12e8f7
to
1607c77
Compare
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 79.86% 79.90% +0.04%
==========================================
Files 30 31 +1
Lines 1967 1976 +9
==========================================
+ Hits 1571 1579 +8
- Misses 322 323 +1
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more.
|
angrieralien
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussions with the team, we decided that the input files will always be named pipes. As a result, we felt it was necessary to enforce a file-type check that produces a helpful error message.