Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take multi-token auth config instead of individual variables #12

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Alva8756
Copy link
Contributor

@Alva8756 Alva8756 commented Jan 11, 2024

This is the patch of metal-toolbox/conditionorc#117

oidc env will no longer be respected. We will need to provide a new config yaml file to k8s-fleetdb in order to config oidc.

Test
Tested with local fleetdb(okta) + local crdb.

@Alva8756 Alva8756 force-pushed the multi_auth branch 3 times, most recently from 096534d to dfa3f12 Compare January 12, 2024 04:13
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb58a27) 72.74% compared to head (8760c98) 72.72%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   72.74%   72.72%   -0.03%     
==========================================
  Files          38       38              
  Lines        3735     3732       -3     
==========================================
- Hits         2717     2714       -3     
  Misses        760      760              
  Partials      258      258              
Flag Coverage Δ
unittests 72.72% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alva8756 Alva8756 changed the title WIP: take multi-token auth config instead of individual variables take multi-token auth config instead of individual variables Jan 12, 2024
Copy link
Contributor

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alva8756 Alva8756 merged commit c5d78b4 into main Jan 16, 2024
3 checks passed
@Alva8756 Alva8756 deleted the multi_auth branch January 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants