FS-1234; Expand DB Schema to allow storing Config Sets #43
Conversation
jakeschuurmans
force-pushed
the
FS-1234
branch
4 times, most recently
from
56ec57c
to
6f4471c
Compare
jakeschuurmans
changed the title
| @@ -21,7 +21,7 @@ jobs: | |||
| go-version: '1.22.1' | |||
|
|
|||
| - name: Install cockroach binary | |||
| run: curl https://binaries.cockroachdb.com/cockroach-v23.1.11.linux-amd64.tgz | tar -xz && sudo cp -i cockroach-v23.1.11.linux-amd64/cockroach /usr/local/bin/ | |||
| run: curl https://binaries.cockroachdb.com/cockroach-v21.1.21.linux-amd64.tgz | tar -xz && sudo cp -i cockroach-v21.1.21.linux-amd64/cockroach /usr/local/bin/ | |||
There was a problem hiding this comment.
getting the CRDB error because the deprecated "crdb drop" command is no longer deprecated, and is now gone. The SQLBoiler version we use still uses drop.
There was a problem hiding this comment.
I'd like us to roll forward with versions and not use older ones in testing.
When you say SQLBoiler, I guess you're referring to the CrDB driver, specifically this https://github.com/metal-toolbox/sqlboiler-crdb/blob/18c5774bdcce987f22ef5ea1b542c2e390faae78/driver/override/templates_test/singleton/crdb_main_test.go.tpl#L56
Can you take a look if that can be updated - as a separate issue.
There was a problem hiding this comment.
We have a ticket for it. FS-1400
This reverts commit f0a153f.
There was a problem hiding this comment.
Nice work here, thanks for improving on the query handling.
Going ahead I'd like us to consider https://github.com/cbrand/go-filterparams since its fairly comprehensive.
Left a few comments and suggestions.
| @@ -21,7 +21,7 @@ jobs: | |||
| go-version: '1.22.1' | |||
|
|
|||
| - name: Install cockroach binary | |||
| run: curl https://binaries.cockroachdb.com/cockroach-v23.1.11.linux-amd64.tgz | tar -xz && sudo cp -i cockroach-v23.1.11.linux-amd64/cockroach /usr/local/bin/ | |||
| run: curl https://binaries.cockroachdb.com/cockroach-v21.1.21.linux-amd64.tgz | tar -xz && sudo cp -i cockroach-v21.1.21.linux-amd64/cockroach /usr/local/bin/ | |||
There was a problem hiding this comment.
I'd like us to roll forward with versions and not use older ones in testing.
When you say SQLBoiler, I guess you're referring to the CrDB driver, specifically this https://github.com/metal-toolbox/sqlboiler-crdb/blob/18c5774bdcce987f22ef5ea1b542c2e390faae78/driver/override/templates_test/singleton/crdb_main_test.go.tpl#L56
Can you take a look if that can be updated - as a separate issue.
Adding Config Sets, unit tests, integration tests, mock tests, and the works to fleetdb.
There is more to talk about than can just be mentioned here in a description . . .
Main thing you might notice that might be alarming is I moved and renamed some of the "Attribute Operators". They have been moved to their own file "query_operators.go" so they can easily be shared.
I am also using urlquery to parse queries into structs and back. We can have a conversation about what we want to use for this purpose. This is the one that worked mostly well for my purpose.
Joel has requested that ConfigSets be renamed to BIOSConfigSets. I will make this change and put it together as its own commit