Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump sigs.k8s.io/testing_frameworks from 0.1.1 to 0.1.2 in /hack/tools #272

Merged
merged 1 commit into from
Aug 21, 2023
Merged

🌱 Bump sigs.k8s.io/testing_frameworks from 0.1.1 to 0.1.2 in /hack/tools #272

merged 1 commit into from
Aug 21, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 16, 2023 •
edited
Loading

Bumps sigs.k8s.io/testing_frameworks from 0.1.1 to 0.1.2.

Release notes

Sourced from sigs.k8s.io/testing_frameworks's releases.

gomod

Main changes:

  • use go modules and remove ./vendor (#69)
  • track if process are ready / have been started successfully (#64)

All changes: kubernetes-retired/testing_frameworks@v0.1.1...v0.1.2

Commits
  • c708704 Merge pull request #69 from mengqiy/gomodules
  • 34a2546 switch to use go modules
  • 1380692 Merge pull request #70 from mengqiy/fixtest
  • 908f8ed Fix a failing test caused by an kubectl output change in 1.16
  • b6c33f5 Merge pull request #66 from mengqiy/joinhostport
  • 9436c77 use net.JoinHostPort instead of Sprintf
  • 57f0744 Merge pull request #64 from s12chung/fix_retry_start_controlplane
  • b5ae484 add comments about process.ready bool state
  • 2d4b018 check if control plane process is Ready before Start()-ing it again
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 16, 2023
@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2023
@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

Need manual changes on top.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tools/sigs.k8s.io/testing_frameworks-0.1.2 branch from fa22722 to ef93309 Compare June 20, 2023 08:17
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2023
furkatgofurov7
furkatgofurov7 previously approved these changes Jul 25, 2023
View reviewed changes
@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

15 similar comments
@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@metal3-io-bot
Copy link
Contributor

Can one of the admins verify this patch?

@furkatgofurov7
Copy link
Member

Need manual changes on top.

/hold

missed this comment

/approve cancel

@furkatgofurov7 furkatgofurov7 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2023
@furkatgofurov7
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tools/sigs.k8s.io/testing_frameworks-0.1.2 branch from ef93309 to 50bc78f Compare August 15, 2023 14:30
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
@dependabot
🌱 Bump sigs.k8s.io/testing_frameworks in /hack/tools
8012091 
Bumps [sigs.k8s.io/testing_frameworks](https://github.com/kubernetes-sigs/testing_frameworks) from 0.1.1 to 0.1.2.
- [Release notes](https://github.com/kubernetes-sigs/testing_frameworks/releases)
- [Commits](kubernetes-retired/testing_frameworks@v0.1.1...v0.1.2)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/testing_frameworks
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tools/sigs.k8s.io/testing_frameworks-0.1.2 branch from 50bc78f to 8012091 Compare August 15, 2023 14:30
@furkatgofurov7
Copy link
Member

Need manual changes on top.

/hold

@tuminoid what changes are needed?

@furkatgofurov7
Copy link
Member

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@tuminoid
Copy link
Member

Need manual changes on top.
/hold

@tuminoid what changes are needed?

No further changes needed. It was failing tests when introduced.

/unhold
/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 21, 2023
@metal3-io-bot metal3-io-bot merged commit 1a4d607 into main Aug 21, 2023
3 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/hack/tools/sigs.k8s.io/testing_frameworks-0.1.2 branch August 21, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metal3-io-bot @tuminoid @furkatgofurov7