Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release-1.9 triggers to other repos #936

Merged

Conversation

tuminoid
Copy link
Member

Add release-1.9 triggers to dev-env, ipa-downloader and mariadb-image.

Update README.md for the new triggers.

Update milestone applier config to use 1.9 branches and milestones correctly.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2024
Add release-1.9 triggers to dev-env, ipa-downloader and mariadb-image.

Update README.md for the new triggers.

Update milestone applier config to use 1.9 branches and milestones
correctly.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/add-1.9-triggers-and-other-config branch from 8684264 to 1b444ab Compare December 18, 2024 08:14
@tuminoid
Copy link
Member Author

/hold
Even though IPAM could use this right now for the milestone applier config, let's not update it until all content in CAPM3 is in, as those PRs would be labelled wrong then.

/override metal3-ubuntu-e2e-integration-test-main
/cc @kashifest @Sunnatillo @Rozzii

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/hold
Even though IPAM could use this right now for the milestone applier config, let's not update it until all content in CAPM3 is in, as those PRs would be labelled wrong then.

/override metal3-ubuntu-e2e-integration-test-main
/cc @kashifest @Sunnatillo @Rozzii

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tuminoid
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@metal3-io-bot metal3-io-bot merged commit a9be2be into metal3-io:main Dec 19, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-1.9-triggers-and-other-config branch December 19, 2024 12:56
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the following 2 configmaps:

  • job-config configmap in namespace prow at cluster default using the following files:
    • key ironic-ipa-downloader.yaml using file prow/config/jobs/metal3-io/ironic-ipa-downloader.yaml
    • key mariadb-image.yaml using file prow/config/jobs/metal3-io/mariadb-image.yaml
    • key metal3-dev-env.yaml using file prow/config/jobs/metal3-io/metal3-dev-env.yaml
  • plugins configmap in namespace prow at cluster default using the following files:
    • key plugins.yaml using file prow/config/plugins.yaml

In response to this:

Add release-1.9 triggers to dev-env, ipa-downloader and mariadb-image.

Update README.md for the new triggers.

Update milestone applier config to use 1.9 branches and milestones correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants