Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old 1.8 tests from required for dev-env #939

Merged
merged 1 commit into from
Dec 20, 2024
Merged

remove old 1.8 tests from required for dev-env #939

merged 1 commit into from
Dec 20, 2024

Conversation

tuminoid
Copy link
Member

We have 1.9 and 1.8 both enabled now. 1.9 test is working, so remove old 1.8.

@tuminoid
remove old 1.8 tests from required for dev-env
f8374c6 
We have 1.9 and 1.8 both enabled now. 1.9 test is working, so remove
old 1.8.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2024
@tuminoid
Copy link
Member Author

/cc @kashifest @Rozzii @mquhuy @adilGhaffarDev

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Rozzii
Rozzii reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

kashifest
kashifest reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@metal3-io-bot metal3-io-bot merged commit 22a0000 into metal3-io:main Dec 20, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/remove-1.8-e2e-from-dev-env branch December 20, 2024 08:54
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key metal3-dev-env.yaml using file prow/config/jobs/metal3-io/metal3-dev-env.yaml

In response to this:

We have 1.9 and 1.8 both enabled now. 1.9 test is working, so remove old 1.8.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@Rozzii Rozzii Rozzii left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @adilGhaffarDev @Rozzii @kashifest