-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix incorrect PR title handling #941
Conversation
/run-workflow pr-verifier |
/run-workflow check-title |
f4952bc
to
f6ed4d0
Compare
/run-workflow |
f6ed4d0
to
6801427
Compare
kubectl get
kubectl get
kubectl get
"
code injection fixed according to test https://github.com/metal3-io/project-infra/actions/runs/12546662618/job/34982853335?pr=941 Issue with the double quotes has been fixed according to https://github.com/metal3-io/project-infra/actions/runs/12546678748/job/34982894750?pr=941#step:3:4 |
kubectl get
"6801427
to
19a6ac3
Compare
/cc @dtantsur @kashifest |
Not relevant: |
@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
19a6ac3
to
f5b5c83
Compare
f5b5c83
to
594fcb3
Compare
kubectl get
"
this looks even better thanks @kashifest https://github.com/metal3-io/project-infra/actions/runs/12547150833/job/34984126406?pr=941#step:3:39 |
594fcb3
to
9221f11
Compare
This commit: - Changes the PR title in the PR verifier script to be a constant string in the BASH context. Signed-off-by: Adam Rozman <[email protected]>
9221f11
to
74fa1b1
Compare
kubectl get
"
Not relevant: |
@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This commit: