Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix incorrect PR title handling #941

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Dec 30, 2024

This commit:

  • Changes the PR title in the PR verifier script to be a constant string in the BASH context.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

/run-workflow pr-verifier

@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

/run-workflow check-title

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

/run-workflow

@Rozzii Rozzii changed the title 🐛 fix incorrect PR title handling 🐛 fix incorrect PR title handling kubectl get Dec 30, 2024
@Rozzii Rozzii changed the title 🐛 fix incorrect PR title handling kubectl get ":bug: fix incorrect PR title handling kubectl get" Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

@Rozzii Rozzii changed the title ":bug: fix incorrect PR title handling kubectl get" 🐛 fix incorrect PR title handling Dec 30, 2024
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

/cc @dtantsur @kashifest

@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

Not relevant:
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

Not relevant:
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 30, 2024
@Rozzii Rozzii changed the title 🐛 fix incorrect PR title handling ":bug: fix incorrect PR title handling ' kubectl get " Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

This commit:
  - Changes the PR title in the PR verifier script to be a constant string
    in the BASH context.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii Rozzii changed the title ":bug: fix incorrect PR title handling ' kubectl get " 🐛 fix incorrect PR title handling Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

Not relevant:
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

Not relevant:
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rozzii Rozzii requested a review from mquhuy December 30, 2024 13:36
@mquhuy
Copy link
Member

mquhuy commented Dec 31, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2024
@metal3-io-bot metal3-io-bot merged commit 33dba47 into metal3-io:main Dec 31, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the fix_pr_verify branch December 31, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants