Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.md and improve config env.mapping list. #3020

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

meowjesty
Copy link
Member

  • Issue: n/a

The list of env var config mapping was being displayed in a single line, so ugly. Changed it to a proper list.

@Razz4780
Copy link
Contributor

It's still a single line in the schema 👀
Maybe you need * instead of -?

@meowjesty
Copy link
Member Author

It's still a single line in the schema 👀 Maybe you need * instead of -?

The schema doesn't render as proper markdown? I'll update it with new lines then, but I think it'll still be a single line.

Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the schema still shows it in a single line (checked in vscode). Though it's an improvement either way, so approving.

If you want, you can try with *s or maybe newlines between the entries

@meowjesty meowjesty enabled auto-merge January 20, 2025 20:33
@meowjesty meowjesty disabled auto-merge January 20, 2025 20:34
@meowjesty meowjesty enabled auto-merge January 20, 2025 20:34
@meowjesty meowjesty added this pull request to the merge queue Jan 20, 2025
Merged via the queue into metalbear-co:main with commit db82881 Jan 20, 2025
17 checks passed
@meowjesty meowjesty deleted the minor/update-configuration-md branch January 20, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants