-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up of # 4648 #4654
Follow up of # 4648 #4654
Conversation
I like the renamings to
|
How would you name a theorem that uses the forward implication then? It clashes with eqabi, the immediate version of eqab. |
Co-authored-by: Benoit <[email protected]>
Co-authored-by: Benoit <[email protected]>
I propose the label |
The suffix "i" is also used as "implication", see the table of label fragments in our Conventions. By the way, the label fragment "ri" should be added to this table. |
could abeq1 be abeq instead of eqabc? Though eqabr would still be eqabr or be something like abeqim |
I wanted to get away from abeq, since this sequence has a different meaning in rabeq and some other theorems. I had to start over again to resolve some surprising clashes in the process of renaming. So I am for this PR against it. |
* abeq2 -> eqab * abeq1 -> eqabc * abeq2impr -> eqab1r * abeq2w -> eqabw * abeq2d -> eqabd * abeq2i -> eqabi * abeq1i -> eqabci * rabeq2i -> reqabi * abeq2f -> eqabf * discouraged * update nf.mm * update mmset.raw.html * update nf.mm * nf.mm again * Update changes-set.txt Co-authored-by: Benoit <[email protected]> * Update changes-set.txt Co-authored-by: Benoit <[email protected]> * rename merged rabeq2i * fix merge problem * eqab1r -> eqabr * fix eqab1r in $j tag --------- Co-authored-by: Benoit <[email protected]>
In #4648 some issues weren't resolved. This PR adds the missing points.
abeqb
was suggested, but the sequenceabeq
has a different meaning in rabeq, and clashes are the consequence. Instead I used the left hand side𝐴 = {𝑥 ∣ 𝜑}
as the name building item and decided to rename this theorem toeqab
(short forequals a class abstraction
) still close to the old name, but unused in set.mm so far.eqabc
, the suffix c usually standing for a commuted form.eqab1r
. The suffix 1 indicates a less expressive variant (implication instead of bi-directional), and the r is short forreverse direction)
. This naming pattern follows that of abbi1. This theorem is located beforeeqab
, as requested by commenters in prove one direction of abeq2 from fewer axioms #4648 . A missing $j tag is now added.I suggest to look through this PR commit by commit for easier review.