rename identity theorems #4674
Merged
rename identity theorems #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkingdon
reviewed
Feb 24, 2025
Thank you very much for this janitorial work. We should perform clean ups as soon as possible after they are detected, otherwise they won't be done in most cases. |
icecream17
reviewed
Feb 24, 2025
set.mm
Outdated
| @@ -129303,13 +129303,13 @@ it could represent the (meaningless) operation of | |||
| $( Subtraction of a number from itself. (Contributed by NM, 8-Oct-1999.) | |||
| (Revised by Mario Carneiro, 27-May-2016.) $) | |||
| subid $p |- ( A e. CC -> ( A - A ) = 0 ) $= | |||
| ( cc wcel cc0 caddc co cmin addid1 oveq1d wceq 0cn pncan2 mpan2 eqtr3d ) AB | |||
| ( cc wcel cc0 caddc co cmin addrid oveq1d wceq 0cn pncan2 mpan2 eqtr3d ) AB | |||
| CZADEFZAGFZAAGFDOPAAGAHIODBCQDJKADLMN $. | |||
|
|
|||
| $( Identity law for subtraction. (Contributed by NM, 9-May-2004.) (Revised | |||
| by Mario Carneiro, 27-May-2016.) $) | |||
| subid1 $p |- ( A e. CC -> ( A - 0 ) = A ) $= | |||
There was a problem hiding this comment.
This could be renamed too
metamath.exe show statement *id1,*id2 can check for possible missed theorems
There was a problem hiding this comment.
There are 73 other theorems of the form *id[12] in set.mm, not all of which fit this pattern. This PR would absolutely balloon out of control if I were to rename all of them here. Could somebody else please go through some of them?
jkingdon
reviewed
Feb 25, 2025
jkingdon
reviewed
Feb 25, 2025
avekens
reviewed
Feb 26, 2025
avekens
requested changes
Feb 26, 2025
avekens
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #4666 this PR renames all the id1 and id2 theorems remaining in set.mm to rid and lid respectively.