Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbi* -> eqab* #4682

Merged
merged 3 commits into from
Mar 1, 2025
Merged

abbi* -> eqab* #4682

merged 3 commits into from
Mar 1, 2025

Conversation

wlammen
Copy link
Contributor

@wlammen wlammen commented Feb 28, 2025

This is the final set of renamings from #4659 . When this PR is done, I will close it as well.

  1. abbi2i -> eqabi
  2. abbi1dv -> eqabcdv
  3. abbi2dv -> eqabdv

This does not mean, we're ready. The next candidate is nabbi, that could be relabelled as nabbib, and have the sides flipped. Your opinions?

@wlammen wlammen merged commit 1ee0e4d into metamath:develop Mar 1, 2025
10 checks passed
@wlammen wlammen deleted the wl-2 branch March 1, 2025 21:31
@icecream17
Copy link
Contributor

icecream17 commented Mar 2, 2025

As for nabbi, the change makes sense. Especially since the current-left hand side is somewhat arbitrary. suppvalbr is the only theorem that uses nabbi, and all that's needed is to change step 11 from 3bitr4i(6, 9, 10) to 3bitri(9, 6, 10c)

Edit: This makes the second example in https://github.com/metamath/set.mm/wiki/Minimizing#commutations outdated, but I will add the examples to my mathbox later (-> section "exemplar theorems", perhaps better renamed "illustrative theorems"). ralcom4 was obsoleted anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants