-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intuitionize subgroups from df-subg to issubg2 #4684
Open
jkingdon
wants to merge
20
commits into
metamath:develop
Choose a base branch
from
jkingdon:subg
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing called SubGroup so refer to SubGrp instead which is what must have been meant.
This is all three syntaxes and df-subg , df-nsg , and df-eqg
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof.
Restricting a group to its base set.
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a little bit of intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a little intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a little bit of intuitionizing but is basically the set.mm proof.
This is ifeq2da from set.mm with a decidability condition added. The proof is based on the iset.mm proof of ifeq1dadc . Correct comment for ifeq1dadc to reflect our conventions.
Stated as in set.mm. The proof needs intuitionizing in several places but is basically the set.mm proof.
This is issubg2 from set.mm with non-empty changed to inhabited. The proof needs intuitionizing but is basically the set.mm proof.
icecream17
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intuitionizing here is pretty easy for the most part. Only one theorem needs to be stated differently and of those proofs which need to change, it isn't in especially big ways.