Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparation for implementation of schema document tables #266

Merged

Conversation

AIS-RyoMukai
Copy link
Contributor

Update buildings and land use pages.

Changes made:
Change class diagram images to those from EA output.
Implementation of klass table
Deletion of old tables

Metanorma PR checklist

Update buildings and land use pages.

Changes made:
Change class diagram images to those from EA output.
Implementation of klass table
Deletion of old tables
Update Building and LandUse pages.

Changes made:
Change class diagram images to those from EA output.
Implementation of klass table
Deletion of old tables
@AIS-RyoMukai AIS-RyoMukai linked an issue Dec 13, 2024 that may be closed by this pull request
@ReesePlews
Copy link
Contributor

hello @AIS-RyoMukai is this ready for a merge?

@AAS-YknKawakita
Copy link
Contributor

hello @ReesePlews (cc:@AIS-RyoMukai)
I was checked output PDF&html files.
I don't think there is any error.
Please merge if there are no problems.

Thank you for your support.

@ReesePlews
Copy link
Contributor

hello @AAS-YknKawakita and @AIS-RyoMukai, in looking at the SVG images, i am wondering if they are not visible because the color of the text of the attributes is not black but some brown-ish color?

instead of removing the call to the .svg image lets just comment that out "//" but keep it in the file. if you can check the color of the text in EA when the SVG is output, then perhaps it is possible to got back to SVG because it is not a metanorma issue but an EA/color issue. brown text with pink background may be the issue.

please update the commit and i will merge when it is finished. thank you.

@AAS-YknKawakita
Copy link
Contributor

hello @ReesePlews
Thank you for checking.
I've reinstated the SVG images with the comment out.
Please check it out. thank you.

@ReesePlews ReesePlews merged commit 5e7d0b5 into main Dec 13, 2024
1 check passed
@ReesePlews
Copy link
Contributor

hello @AAS-YknKawakita thank you for making the updates. on the next PRs i think we should label them someway so we know sub-clause we are working on. you added "Update buildings and land use pages." but perhaps the clause numbers are helpful to have in the title of the PR. the idea is to be able to find which PR goes with which sub-clause quickly, if needed. please consider that. thank you.

@AIS-RyoMukai AIS-RyoMukai deleted the 262-preparation-for-implementation-of-schema-document-tables branch January 9, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparation for implementation of schema document tables.
3 participants