Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numbering from the title of the cited standard #317

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Remove numbering from the title of the cited standard #317

merged 2 commits into from
Jan 22, 2025

Conversation

AIS-RyoMukai
Copy link
Contributor

Metanorma PR checklist

@AIS-RyoMukai AIS-RyoMukai self-assigned this Jan 21, 2025
@AIS-RyoMukai AIS-RyoMukai linked an issue Jan 21, 2025 that may be closed by this pull request
Issue for test branch：Remove numbering from the title of the cited standard： #316
Closed
ReesePlews
ReesePlews reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ReesePlews ReesePlews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have never seen this done before. technically it is not wrong. if the render was what you expected than there is no problem to accept this.

@AIS-RyoMukai
Copy link
Contributor Author

@ReesePlews @AAS-YknKawakita
I think there will be no problem.

@ReesePlews
updated i18n yaml file path
a18df81 
the corrected path is config/plateau_i18n-ja.yaml
@ReesePlews ReesePlews merged commit e240fc1 into main Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReesePlews ReesePlews ReesePlews left review comments

Assignees

@AIS-RyoMukai AIS-RyoMukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue for test branch：Remove numbering from the title of the cited standard：
2 participants
@AIS-RyoMukai @ReesePlews