MTG-750 Calculating bubblegum and account checksums #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snorochevskiy
force-pushed
the
MTG-688_consistency_checksum
branch
from
0c84d5c
to
ba9fa93
Compare
n00m4d
reviewed
Oct 24, 2024
| hasher = Hasher::default(); | ||
| } | ||
| hasher.hash(&k); | ||
| hasher.hash(&v); |
There was a problem hiding this comment.
Why do we save value as well? Why not only key or value?
There was a problem hiding this comment.
@n00m4d
I assume that theoretically (not sure how high the probability is) we might have a situation, when on different peers there are bubblegum changes with same pubkey+slot+seq, but different signatures.
It you believe that this is impossible, then I can remove the signature from the bubblegum change entity (and from the hashing).
There was a problem hiding this comment.
hmmm, not sure either. Ok let's leave it for now 😅
n00m4d
reviewed
Oct 24, 2024
snorochevskiy
force-pushed
the
MTG-688_consistency_checksum
branch
2 times, most recently
from
f3636c6
to
b504cad
Compare
snorochevskiy
changed the title
snorochevskiy
force-pushed
the
MTG-688_consistency_checksum
branch
from
b504cad
to
23cb90a
Compare
snorochevskiy
force-pushed
the
MTG-688_consistency_checksum
branch
from
7cd234a
to
8595abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary code review that doesn't intend to be me merged into the main branch, but aims to reveal problems before the development in completed.
In scope of review, I would like to present:
See the technical design:
https://github.com/adm-metaex/doc/wiki/Data-consistency-for-peer%E2%80%90to%E2%80%90peer-indexers