Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotations mismatch for neutral loss #22

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Fix annotations mismatch for neutral loss #22

merged 4 commits into from
Mar 16, 2024

Conversation

aeisenbarth
Copy link
Collaborator

Solves #21

@aeisenbarth aeisenbarth marked this pull request as ready for review March 11, 2024 11:00
@tdrose tdrose self-requested a review March 11, 2024 14:43
tdrose
tdrose reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@tdrose tdrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

metaspace_converter/tests/to_anndata_test.py Show resolved Hide resolved
metaspace_converter/to_anndata.py Show resolved Hide resolved
@tdrose
Copy link
Member

tdrose commented Mar 14, 2024

@aeisenbarth Just noticed. Could you to a version bump, such that we can make a new release and the package on pypi will be updated with the fix.

tdrose
tdrose approved these changes Mar 16, 2024
View reviewed changes
metaspace_converter/to_anndata.py Show resolved Hide resolved
@tdrose tdrose merged commit d0fa972 into master Mar 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdrose tdrose tdrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenbarth @tdrose