Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Guillaume Fraux <[email protected]>
  • Loading branch information
PicoCentauri and Luthaf committed Jun 5, 2024
1 parent 0e1cb5c commit a93f919
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
- [ ] Compatibility with JIT compilation using `TorchScript
<https://pytorch.org/docs/stable/jit.html>`_.
- [ ] Provision of reasonable default hyperparameters.
- [ ] A contact person designated as the maintainer.
- [ ] A contact person designated as the maintainer, mentioned in `__maintainers__` and the `CODEOWNERS` file
- [ ] All external dependencies must be pip-installable. While not required to be on
PyPI, a public git repository or another public URL with a repository is acceptable.

Expand Down
7 changes: 4 additions & 3 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ Then this package itself

.. code-block:: bash
git clone https://github.com/lab-cosmo/metatensor-models cd metatensor-models pip
install -e .
git clone https://github.com/lab-cosmo/metatensor-models
cd metatensor-models
pip install -e .
This install the package in development mode, making it importable globally and allowing
you to edit the code and directly use the updated version. To see a list of all
Expand Down Expand Up @@ -96,7 +97,7 @@ If you want to test a specific archicture you can also do it. For example
tox -e soap-bpnn-tests
Will run the unit and regression tests for the :ref:`SOAP-BPNN <architecture-soap-bpnn>`
model. Note that architecture tests are not run by default if yiu just type ``tox``.
model. Note that architecture tests are not run by default if you just type ``tox``.

.. _unittest: https://docs.python.org/3/library/unittest.html
.. _tox: https://tox.readthedocs.io/en/latest
Expand Down

0 comments on commit a93f919

Please sign in to comment.