Rename "structure(s)" -> "system(s)" #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a part a typo is ok, when it passes the CI |
DavideTisi
reviewed
Feb 26, 2024
docs/src/getting-started/usage.rst
Outdated
| @@ -21,7 +21,7 @@ Training | |||
| To train models, `metatensor-models` uses the hydra framework. Hydra is a framework | |||
| developed by Facebook AI for elegantly configuring complex applications. It's primarily | |||
| used for managing command-line arguments in Python applications, allowing for a | |||
| structured and dynamic approach to configuration. It allows to dynamical composition and | |||
| systemd and dynamic approach to configuration. It allows to dynamical composition and | |||
There was a problem hiding this comment.
Suggested change
| systemd and dynamic approach to configuration. It allows to dynamical composition and | |
| structured and dynamic approach to configuration. It allows to dynamical composition and |
PicoCentauri
force-pushed
the
rename-systems
branch
from
1cf05f4
to
2c79042
Compare
PicoCentauri
force-pushed
the
rename-systems
branch
from
2c79042
to
b653af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue our renaming actions, this PR adjusts the names for systems. The only place where the name
structurestill appears is inrascaline.torch.AtomicComposition(per_structure=True), which will be fixed in rascaline directlty.📚 Documentation preview 📚: https://metatensor-models--110.org.readthedocs.build/en/110/