Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move normalize.py to utils of alchemical_model #115

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

frostedoyster
Copy link
Collaborator

@frostedoyster frostedoyster commented Feb 29, 2024

This module is not tested and it is also not being used by other models at the moment


📚 Documentation preview 📚: https://metatensor-models--115.org.readthedocs.build/en/115/

@PicoCentauri
Copy link
Contributor

If writing a simple test for this is too much effort I am fine with moving this for now.

Please remove also the documentation page for this file and its entry in the index.rst accordingly. The files are indocs/src/dev-docs/utils/normalize.rst and docs/src/dev-docs/utils/index.rst

@PicoCentauri PicoCentauri merged commit ffaf7b8 into main Feb 29, 2024
10 checks passed
@PicoCentauri PicoCentauri deleted the move-normalize branch February 29, 2024 12:38
@Luthaf
Copy link
Member

Luthaf commented Feb 29, 2024

in general, I think code should be in the main utils only if it is used by two or more architectures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants