-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not disable rascaline's logger #147
Conversation
src/metatensor/models/utils/io.py
Outdated
import rascaline.torch # noqa: F401 | ||
|
||
rascaline.set_logging_callback(lambda x, y: None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is problematic because it will also suppress the warnings. Maybe something like
from rascaline.log import RASCAL_LOG_LEVEL_WARN, RASCAL_LOG_LEVEL_ERROR
def rascaline_logging(level, message):
if level in [RASCAL_LOG_LEVEL_WARN, RASCAL_LOG_LEVEL_ERROR]:
rascaline.log.default_logging_callback(level, message)
rascaline.set_logging_callback(rascaline_logging)
Another solution would be to move the spline message to debug
instead of info
level in rascaline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fair, I will do this.
But how will we do this when rascaline won't be imported explicitly in Python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean for eval?
Another solution would be to move the spline message to debug instead of info level in rascaline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean for eval
Following Luthaf/rascaline#289, this pull request will be about removing the filtering of warnings and errors from rascaline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, should we wait for the rascaline PR & also update the pinned commit?
Yes, indeed |
Without these changes, evaluating the SOAP-BPNN looks like this on my laptop. However, I don't think this is a sustainable solution because we have to import rascaline
📚 Documentation preview 📚: https://metatensor-models--147.org.readthedocs.build/en/147/