Account for empty validation and test sets #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately no because the user can also specify their own validation set instead of using fractions |
|
I don't see how a dataset can be empty if successfully read something from disk? |
|
Hmm ok, then that's an issue because, in my opinion, we should allow empty validation sets, as long as they aren't all empty. Perhaps this should be allowed in a different PR though |
|
How do you think would the syntax for something like this look like? |
|
I don't yet know if and how we should allow it. Perhaps we should discuss it with the whole crew. For now, I will go with your suggestions |
src/metatensor/models/cli/train.py
Outdated
| @@ -305,7 +305,7 @@ def _train_model_hydra(options: DictConfig) -> None: | |||
| validation_size = validation_options | |||
| train_size -= validation_size | |||
|
|
|||
| if validation_size < 0 or validation_size >= 1: | |||
| if validation_size <= 0 or validation_size >= 1: | |||
| raise ValueError("Validation set split must be between 0 and 1.") | |||
There was a problem hiding this comment.
Suggested change
| raise ValueError("Validation set split must be between 0 and 1.") | |
| raise ValueError("Validation set split must be larger than 0 and smaller than 1.") |
There was a problem hiding this comment.
Ok, then also for the training set...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
📚 Documentation preview 📚: https://metatensor-models--152.org.readthedocs.build/en/152/